Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3
Patch Set: Removed unnecessary crbug comment. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 420 matching lines...) Expand 10 before | Expand all | Expand 10 after
431 const blink::WebPopupMenuInfo& popup_menu_info, 431 const blink::WebPopupMenuInfo& popup_menu_info,
432 blink::WebExternalPopupMenuClient* popup_menu_client) override; 432 blink::WebExternalPopupMenuClient* popup_menu_client) override;
433 blink::WebCookieJar* cookieJar(blink::WebLocalFrame* frame) override; 433 blink::WebCookieJar* cookieJar(blink::WebLocalFrame* frame) override;
434 blink::WebServiceWorkerProvider* createServiceWorkerProvider( 434 blink::WebServiceWorkerProvider* createServiceWorkerProvider(
435 blink::WebLocalFrame* frame) override; 435 blink::WebLocalFrame* frame) override;
436 void didAccessInitialDocument(blink::WebLocalFrame* frame) override; 436 void didAccessInitialDocument(blink::WebLocalFrame* frame) override;
437 blink::WebFrame* createChildFrame( 437 blink::WebFrame* createChildFrame(
438 blink::WebLocalFrame* parent, 438 blink::WebLocalFrame* parent,
439 blink::WebTreeScopeType scope, 439 blink::WebTreeScopeType scope,
440 const blink::WebString& name, 440 const blink::WebString& name,
441 const blink::WebString& uniqueName,
alexmos 2016/02/10 00:46:46 nit: unique_name? (and maybe fix sandbox_flags whi
Łukasz Anforowicz 2016/02/10 22:10:51 Done.
441 blink::WebSandboxFlags sandboxFlags, 442 blink::WebSandboxFlags sandboxFlags,
442 const blink::WebFrameOwnerProperties& frameOwnerProperties) override; 443 const blink::WebFrameOwnerProperties& frameOwnerProperties) override;
443 void didChangeOpener(blink::WebFrame* frame) override; 444 void didChangeOpener(blink::WebFrame* frame) override;
444 void frameDetached(blink::WebFrame* frame, DetachType type) override; 445 void frameDetached(blink::WebFrame* frame, DetachType type) override;
445 void frameFocused() override; 446 void frameFocused() override;
446 void willClose(blink::WebFrame* frame) override; 447 void willClose(blink::WebFrame* frame) override;
447 void didChangeName(blink::WebLocalFrame* frame, 448 void didChangeName(blink::WebLocalFrame* frame,
448 const blink::WebString& name) override; 449 const blink::WebString& name,
450 const blink::WebString& unique_name) override;
449 void didEnforceStrictMixedContentChecking() override; 451 void didEnforceStrictMixedContentChecking() override;
450 void didChangeSandboxFlags(blink::WebFrame* child_frame, 452 void didChangeSandboxFlags(blink::WebFrame* child_frame,
451 blink::WebSandboxFlags flags) override; 453 blink::WebSandboxFlags flags) override;
452 void didChangeFrameOwnerProperties( 454 void didChangeFrameOwnerProperties(
453 blink::WebFrame* child_frame, 455 blink::WebFrame* child_frame,
454 const blink::WebFrameOwnerProperties& frame_owner_properties) override; 456 const blink::WebFrameOwnerProperties& frame_owner_properties) override;
455 void didMatchCSS( 457 void didMatchCSS(
456 blink::WebLocalFrame* frame, 458 blink::WebLocalFrame* frame,
457 const blink::WebVector<blink::WebString>& newly_matching_selectors, 459 const blink::WebVector<blink::WebString>& newly_matching_selectors,
458 const blink::WebVector<blink::WebString>& stopped_matching_selectors) 460 const blink::WebVector<blink::WebString>& stopped_matching_selectors)
(...skipping 740 matching lines...) Expand 10 before | Expand all | Expand 10 after
1199 #endif 1201 #endif
1200 1202
1201 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1203 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1202 1204
1203 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1205 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1204 }; 1206 };
1205 1207
1206 } // namespace content 1208 } // namespace content
1207 1209
1208 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1210 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698