third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-capture.html - Issue 1635863006: Pointerevent capture APIs

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-capture.html

Issue 1635863006: Pointerevent capture APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-capture-expected.txt » ('j') | third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <script src="../../../resources/js-test.js"></script>

	3 <style>

	4 div.box {

	5 margin: 5px;

	6 padding: 20px;

	7 float: left;

	8 }

	9 </style>

	10

	11 <div id="grey" class="box" style="background-color:grey">

	12 <div id="green" class="box" style="background-color:green;">

	13 </div>

	14 </div>

	15 <div id="blue" class="box" style="background-color:blue;">

	16 </div>

	17

	18 <div id="console"></div>

	19

	20 <script>

	21 description("Verifies that pointer capture APIs functionality.");
	mustaq 2016/02/06 04:36:31 Perhaps: "Verifies that pointer capture works for Perhaps: "Verifies that pointer capture works for mouse."? Navid Zolghadr 2016/02/08 15:58:42 Will do. Show quoted text On 2016/02/06 04:36:31, mustaq wrote: > Perhaps: "Verifies that pointer capture works for mouse."? Will do.
	22

	23 var seqNo = 0;

	24

	25 function init() {

	26 var eventList = ["mouseenter", "mouseleave", "mouseover", "mouseout", "mouse1m ove", "mousedown", "mouseup",

	27 "pointerenter", "pointerleave", "pointerover", "pointerout", "pointer1move", "pointerdown", "pointerup"];

	28

	29 ["grey", "green", "blue"].forEach(function(id) {

	30 var targetDiv = document.getElementById(id);

	31 eventList.forEach(function(eventName) {

	32 targetDiv.addEventListener(eventName, function(event) {

	33 debug(++seqNo + " " + id + " received " + event.type);

	34 if (id == "green" && event.type == "pointerdown") {

	35 debug(" ======= Set Pointer Capture ======= ");

	36 targetDiv.setPointerCapture(event.pointerId);
	mustaq 2016/02/06 04:36:31 Are we testing only "setPointerCapture()" and not Are we testing only "setPointerCapture()" and not explicit "releasePointerCapture()"? Navid Zolghadr 2016/02/08 15:58:42 You are right. I totally missed that. I will add t Show quoted text On 2016/02/06 04:36:31, mustaq wrote: > Are we testing only "setPointerCapture()" and not explicit > "releasePointerCapture()"? You are right. I totally missed that. I will add the tests for that as well.
	37 }

	38 });

	39 });

	40

	41 });

	42 }

	43

	44 function runTests() {

	45 var rect = document.getElementById("green").getBoundingClientRect();

	46 var x1 = rect.left + 5;

	47 var y1 = rect.top + 5;

	48

	49 var rect = document.getElementById("grey").getBoundingClientRect();

	50 var x2 = rect.left + 5;

	51 var y2 = rect.top + 5;

	52

	53 var rect = document.getElementById("blue").getBoundingClientRect();

	54 var x3 = rect.left + 5;

	55 var y3 = rect.top + 5;

	56

	57 eventSender.mouseMoveTo(x1, y1);
	mustaq 2016/02/06 04:36:31 It's hard to match the long output to the input ta It's hard to match the long output to the input tasks. Please consider these: - Don't output a message unless event.eventPhase == Event.AT_TARGET - Print a few strings in runTests to mark "task" groups in output. - Nuke unrelated tasks, e.g., the first two mouseMoveTo's. Navid Zolghadr 2016/02/08 15:58:42 Sure. Show quoted text On 2016/02/06 04:36:31, mustaq wrote: > It's hard to match the long output to the input tasks. Please consider these: > - Don't output a message unless event.eventPhase == Event.AT_TARGET > - Print a few strings in runTests to mark "task" groups in output. > - Nuke unrelated tasks, e.g., the first two mouseMoveTo's. Sure.
	58 eventSender.mouseMoveTo(x2, y2);

	59 eventSender.mouseMoveTo(x3, y3);

	60 eventSender.mouseDown(1);

	61 eventSender.mouseUp(1);

	62 eventSender.mouseMoveTo(x1, y1);

	63 eventSender.mouseDown(1);

	64 eventSender.mouseMoveTo(x1+1, y1+1);

	65 eventSender.mouseMoveTo(x2, y2);

	66 eventSender.mouseMoveTo(x2+1, y2+1);

	67 eventSender.mouseMoveTo(x3, y3);

	68 eventSender.mouseMoveTo(x1, y1);

	69 eventSender.mouseMoveTo(x3, y3);

	70 eventSender.mouseUp(1);

	71 }

	72

	73 init();

	74 if (window.eventSender)

	75 runTests();

	76 else

	77 debug("This test requires eventSender");

	78

	79 </script>

OLD	NEW