Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1635863005: Suppress leaks happened after making platform/heap to use USING_FAST_MALLOC (Closed)

Created:
4 years, 11 months ago by tasak
Modified:
4 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress leaks happened after making platform/heap to use USING_FAST_MALLOC Failures are: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%282%29/builds/52771 http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%282%29/builds/7261 These are caused by DEFINE_STATIC_REF / DEFINE_STATIC_LOCAL with Persistent. The leaks are expected. BUG=562431 Committed: https://crrev.com/b24cb4882f2bb1f35e9c1e9431fdc140ed46a896 Cr-Commit-Position: refs/heads/master@{#371487}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tasak
PTAL?
4 years, 11 months ago (2016-01-26 09:52:42 UTC) #3
haraken
LGTM
4 years, 11 months ago (2016-01-26 09:54:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635863005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635863005/1
4 years, 11 months ago (2016-01-26 09:56:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 10:18:58 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 10:19:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b24cb4882f2bb1f35e9c1e9431fdc140ed46a896
Cr-Commit-Position: refs/heads/master@{#371487}

Powered by Google App Engine
This is Rietveld 408576698