fpdfsdk/src/fsdk_annothandler.cpp - Issue 1635853002: XFA: Fix a bunch of pointless returns.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fsdk_annothandler.cpp

Issue 1635853002: XFA: Fix a bunch of pointless returns. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fsdk_annothandler.cpp

diff --git a/fpdfsdk/src/fsdk_annothandler.cpp b/fpdfsdk/src/fsdk_annothandler.cpp

index 08d33a2e37b3d9aa4b48c1381f82adc516741ae8..395e3a0f5d8effc7c40ddee347bd66fe1dd1839b 100644

--- a/fpdfsdk/src/fsdk_annothandler.cpp

+++ b/fpdfsdk/src/fsdk_annothandler.cpp

@@ -243,7 +243,6 @@ void CPDFSDK_AnnotHandlerMgr::Annot_OnMouseEnter(CPDFSDK_PageView* pPageView,

if (IPDFSDK_AnnotHandler* pAnnotHandler = GetAnnotHandler(pAnnot)) {

Tom Sepez 2016/01/26 00:15:38 nit: no {}.

Lei Zhang 2016/01/26 00:31:02 Done.

pAnnotHandler->OnMouseEnter(pPageView, pAnnot, nFlag);

}

- return;

}

void CPDFSDK_AnnotHandlerMgr::Annot_OnMouseExit(CPDFSDK_PageView* pPageView,

@@ -254,7 +253,6 @@ void CPDFSDK_AnnotHandlerMgr::Annot_OnMouseExit(CPDFSDK_PageView* pPageView,

if (IPDFSDK_AnnotHandler* pAnnotHandler = GetAnnotHandler(pAnnot)) {

Tom Sepez 2016/01/26 00:15:38 nit: no {}

Lei Zhang 2016/01/26 00:31:02 Done.

pAnnotHandler->OnMouseExit(pPageView, pAnnot, nFlag);

}

- return;

}

FX_BOOL CPDFSDK_AnnotHandlerMgr::Annot_OnChar(CPDFSDK_Annot* pAnnot,

« no previous file with comments | « no previous file | fpdfsdk/src/fsdk_baseannot.cpp » ('j') | xfa/src/fee/src/fee/fde_txtedtengine.cpp » ('J')