Add GYP flag to optionally enable the Hangout Services extension in

Add GYP flag to optionally enable the Hangout Services extension in
any build (not just Chrome-branded builds).

BUG=343567
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251350

[Jói, 2014-02-13 15:30:48]

Once this change lands, an include.gypi file like the following will enable the
extension:

{
  'variables': {
    'enable_hangout_services_extension': 1,
  },
}

Cheers,
Jói

[Jói, 2014-02-13 15:31:19]

+jochen for OWNERS stamp.

[tommi (sloooow) - chröme, 2014-02-13 15:32:48]

lgtm

[jochen (gone - plz use gerrit), 2014-02-13 15:33:34]

lgtm

[Jói, 2014-02-13 21:44:55]

The CQ bit was checked by joi@chromium.org

[commit-bot: I haz the power, 2014-02-13 21:49:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/163583004/1

[commit-bot: I haz the power, 2014-02-13 22:12:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 22:12:43]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[tommi (sloooow) - chröme, 2014-02-14 08:23:57]

The CQ bit was checked by tommi@chromium.org

[commit-bot: I haz the power, 2014-02-14 08:43:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/163583004/1

[commit-bot: I haz the power, 2014-02-14 08:45:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-14 08:45:18]

Try jobs failed on following builders: linux_chromium_rel

[tommi (sloooow) - chröme, 2014-02-14 09:29:06]

I think there's a missing step/hack to copy the variable to the outer scope in
common.gypi.
See e.g.:
 'enable_enhanced_bookmarks%' : '<(enable_enhanced_bookmarks)',

[Jói, 2014-02-14 10:45:56]

Ah, I tested with the variable set, and it worked fine, but didn't
test without it set :)

On Fri, Feb 14, 2014 at 9:29 AM,  <tommi@chromium.org> wrote:
> I think there's a missing step/hack to copy the variable to the outer scope
> in
> common.gypi.
> See e.g.:
>  'enable_enhanced_bookmarks%' : '<(enable_enhanced_bookmarks)',
>
> https://codereview.chromium.org/163583004/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Jói, 2014-02-14 11:38:11]

I added the one-liner to copy to outer scope and tested locally with and without
the GYP variable set. Looks like it works now, pulling the CQ trigger.

[Jói, 2014-02-14 11:38:15]

The CQ bit was checked by joi@chromium.org

[Jói, 2014-02-14 11:38:22]

The CQ bit was checked by joi@chromium.org

[commit-bot: I haz the power, 2014-02-14 11:38:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/163583004/530001

[commit-bot: I haz the power, 2014-02-14 14:25:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-14 14:25:27]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[Jói, 2014-02-14 14:28:39]

The CQ bit was checked by joi@chromium.org

[commit-bot: I haz the power, 2014-02-14 14:29:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/163583004/530001

[commit-bot: I haz the power, 2014-02-14 16:40:45]

Change committed as 251350