Introduce the chroot_cmd flag that contains the command line prefix for running in a chrooted envir…

Introduce the chroot_cmd flag that contains the command line prefix for running in a chrooted environment.

Right now when supplying a 32-bit sysroot via the 'sysroot' GYP flag on a 64-bit host arch,
pkg-config (and pkg-config-wrapper) fail to generate the correct 32-bit paths within that sysroot.
The solution is to chroot into that directory and run pkg-config from there.
This is intended to work with schroot scripts like 'precise32' generated when running build/install-chroot.sh

BUG=324207
R=piman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251353

[Alexander Potapenko, 2014-02-13 15:04:30]

Please take a look

[piman, 2014-02-13 19:00:27]

On 2014/02/13 15:04:30, Alexander Potapenko wrote:
> Please take a look

Why does sysroot= not work?
I use this for Chrome OS builds (against 32bit board chroots), and it gives be
the right result.

[piman, 2014-02-13 19:02:26]

LGTM anyway for latency round trip reasons, 'cause I don't feel strongly about
this if it solves a real problem.

[Alexander Potapenko, 2014-02-13 19:30:35]

The sysroot flag makes the buildsystem run the 64-bit pkg-config on a
32-bit chroot, but pkg-config isn't smart enough to generate paths
containing i386 instead of x86_64. I'm guessing that's because it doesn't
have a notion of arch.
On Feb 13, 2014 11:00 PM, <piman@chromium.org> wrote:

> On 2014/02/13 15:04:30, Alexander Potapenko wrote:
>
>> Please take a look
>>
>
> Why does sysroot= not work?
> I use this for Chrome OS builds (against 32bit board chroots), and it
> gives be
> the right result.
>
> https://codereview.chromium.org/163583003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexander Potapenko, 2014-02-14 07:50:48]

For the record, here's the example:

$  pkg-config --cflags glib-2.0
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include  

$ PKG_CONFIG_SYSROOT_DIR=/var/lib/chroot/precise32bit pkg-config --cflags
glib-2.0
-I/var/lib/chroot/precise32bit/usr/include/glib-2.0
-I/var/lib/chroot/precise32bit/usr/lib/x86_64-linux-gnu/glib-2.0/include  

Committing the patch now.

[Alexander Potapenko, 2014-02-14 16:58:48]

Committed patchset #1 manually as r251353 (presubmit successful).

[piman, 2014-02-14 19:35:24]

On Thu, Feb 13, 2014 at 11:50 PM, <glider@chromium.org> wrote:

> For the record, here's the example:
>
> $  pkg-config --cflags glib-2.0
> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
>
> $ PKG_CONFIG_SYSROOT_DIR=/var/lib/chroot/precise32bit pkg-config --cflags
> glib-2.0
> -I/var/lib/chroot/precise32bit/usr/include/glib-2.0
> -I/var/lib/chroot/precise32bit/usr/lib/x86_64-linux-gnu/glib-2.0/include
>

pkg-config-wrapper will rewrite the -I lines so that they're relative to
the sysroot.


>
> Committing the patch now.
>
> https://codereview.chromium.org/163583003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexander Potapenko, 2014-02-14 19:45:55]

Yet it won't replace x86_64 with i386.
On Feb 14, 2014 11:35 PM, "Antoine Labour" <piman@chromium.org> wrote:

>
>
>
> On Thu, Feb 13, 2014 at 11:50 PM, <glider@chromium.org> wrote:
>
>> For the record, here's the example:
>>
>> $  pkg-config --cflags glib-2.0
>> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
>>
>> $ PKG_CONFIG_SYSROOT_DIR=/var/lib/chroot/precise32bit pkg-config --cflags
>> glib-2.0
>> -I/var/lib/chroot/precise32bit/usr/include/glib-2.0
>> -I/var/lib/chroot/precise32bit/usr/lib/x86_64-linux-gnu/glib-2.0/include
>>
>
> pkg-config-wrapper will rewrite the -I lines so that they're relative to
> the sysroot.
>
>
>>
>> Committing the patch now.
>>
>> https://codereview.chromium.org/163583003/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.