Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1635823003: PPC: [es6] Tail calls support. (Closed)

Created:
4 years, 11 months ago by MTBrandyberry
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [es6] Tail calls support. Port 6131ab1edd6e78be01ac90b8f0b0f4f27f308071 Original commit message: This CL implements PrepareForTailCall() mentioned in ES6 spec for full codegen, Crankshaft and Turbofan. When debugger is active tail calls are disabled. Tail calling can be enabled by --harmony-tailcalls flag. R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4698 LOG=Y Committed: https://crrev.com/95aedaa0c853749649c257fdf7b50cfe5be0eda4 Cr-Commit-Position: refs/heads/master@{#33524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -16 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +11 lines, -7 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/ppc/builtins-ppc.cc View 6 chunks +145 lines, -6 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
MTBrandyberry
4 years, 11 months ago (2016-01-26 16:23:00 UTC) #1
Igor Sheludko
lgtm
4 years, 11 months ago (2016-01-26 16:34:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635823003/1
4 years, 11 months ago (2016-01-26 16:38:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 16:58:01 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 16:58:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95aedaa0c853749649c257fdf7b50cfe5be0eda4
Cr-Commit-Position: refs/heads/master@{#33524}

Powered by Google App Engine
This is Rietveld 408576698