Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: Source/core/page/WindowFeatures.cpp

Issue 16358008: Allow parsing of custom window features, such as 'moo=foo'. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Style change. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Harri Porten (porten@kde.org) 2 * Copyright (C) 2000 Harri Porten (porten@kde.org)
3 * Copyright (C) 2006 Jon Shier (jshier@iastate.edu) 3 * Copyright (C) 2006 Jon Shier (jshier@iastate.edu)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights resev ed. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights resev ed.
5 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Lesser General Public 8 * modify it under the terms of the GNU Lesser General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 else if (keyString == "toolbar") 149 else if (keyString == "toolbar")
150 toolBarVisible = value; 150 toolBarVisible = value;
151 else if (keyString == "location") 151 else if (keyString == "location")
152 locationBarVisible = value; 152 locationBarVisible = value;
153 else if (keyString == "status") 153 else if (keyString == "status")
154 statusBarVisible = value; 154 statusBarVisible = value;
155 else if (keyString == "fullscreen") 155 else if (keyString == "fullscreen")
156 fullscreen = value; 156 fullscreen = value;
157 else if (keyString == "scrollbars") 157 else if (keyString == "scrollbars")
158 scrollbarsVisible = value; 158 scrollbarsVisible = value;
159 else if (value == 1) 159 else {
160 additionalFeatures.append(keyString); 160 // We're dealing with an unknown key, so just pass it on for processing
161 // at a later time.
162 String keyValueStr = keyString;
163 if (!valueString.isEmpty())
164 keyValueStr.append("=" + valueString);
165
166 additionalFeatures.append(keyValueStr);
167 }
161 } 168 }
162 169
163 WindowFeatures::WindowFeatures(const String& dialogFeaturesString, const FloatRe ct& screenAvailableRect) 170 WindowFeatures::WindowFeatures(const String& dialogFeaturesString, const FloatRe ct& screenAvailableRect)
164 : widthSet(true) 171 : widthSet(true)
165 , heightSet(true) 172 , heightSet(true)
166 , menuBarVisible(false) 173 , menuBarVisible(false)
167 , toolBarVisible(false) 174 , toolBarVisible(false)
168 , locationBarVisible(false) 175 , locationBarVisible(false)
169 , fullscreen(false) 176 , fullscreen(false)
170 , dialog(true) 177 , dialog(true)
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 if (separatorPosition != notFound) { 263 if (separatorPosition != notFound) {
257 value = featureString.substring(separatorPosition + 1).stripWhiteSpa ce().lower(); 264 value = featureString.substring(separatorPosition + 1).stripWhiteSpa ce().lower();
258 value = value.left(value.find(' ')); 265 value = value.left(value.find(' '));
259 } 266 }
260 267
261 map.set(key, value); 268 map.set(key, value);
262 } 269 }
263 } 270 }
264 271
265 } // namespace WebCore 272 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698