Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1635783003: Fix mojo_js_unittests. (Closed)

Created:
4 years, 10 months ago by yzshen1
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mojo_js_unittests. ScopedConstants.TEN_TOO has been removed from mojom. BUG=None Committed: https://crrev.com/08c121a4fcb8294152f909916aab509f8436c80a Cr-Commit-Position: refs/heads/master@{#371618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M mojo/public/js/struct_unittests.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks!
4 years, 10 months ago (2016-01-26 18:29:57 UTC) #2
sky
LGTM
4 years, 10 months ago (2016-01-26 21:46:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635783003/1
4 years, 10 months ago (2016-01-26 22:03:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-26 22:24:32 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-26 22:26:13 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/08c121a4fcb8294152f909916aab509f8436c80a
Cr-Commit-Position: refs/heads/master@{#371618}

Powered by Google App Engine
This is Rietveld 408576698