Restore old supermixin functionality to shared language tests.

Restore old supermixin functionality to shared language tests.

In 451eaab71824d51d50a618f374a74bff578801f0 the "--supermixin" flag was
removed from the VM and from the shared language tests.  This caused
those language tests to fail on analyzer (because analyzer still
requires the flag).

Also some tests that validated the non-supermixin behavior were deleted.

It looks like we are going to keep requiring the flag in analyzer until
the feature is implemented in dart2js (see
https://github.com/dart-lang/sdk/issues/24478#issuecomment-170054303).
So in order to ensure that the analyzer implementation continues to be
tested, we still need the flags in the tests.  We also need the old
tests that validate the non-supermixin behavior, since the analyzer
continues to implement that behavior when the "--supermixin" flag is
absent.

This CL does not introduce any new VM failures, because (a) the VM
ignores the "--supermixin" flag, so the tests in which the flag is being
reintroduced will still behave the same way on the VM, and (b) the tests
that validate non-supermixin behavior are disabled on the VM.

R=brianwilkerson@google.com, regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/afc2c880a6080d83afa8af3247844791cee5ab29

[Paul Berry, 2016-01-26 00:26:21]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, regis@google.com

[Brian Wilkerson, 2016-01-26 01:12:02]

LGTM

[regis, 2016-01-26 01:42:59]

lgtm with one comment.

For the record, I was asked to remove the flag from the vm in October.

https://codereview.chromium.org/1635763003/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/1635763003/diff/1/tests/language/language.sta...
tests/language/language.status:11: mixin_illegal_superclass_test: Skip #
"--supermixin" functionality already switched on in VM
Please, refer an issue so that we know when to remove these lines.

[regis, 2016-01-26 01:43:00]

lgtm with one comment.

For the record, I was asked to remove the flag from the vm in October.

[Paul Berry, 2016-01-26 16:50:25]

Description was changed from

==========
Restore old supermixin functionality to shared language tests.

In 451eaab71824d51d50a618f374a74bff578801f0 the "--supermixin" flag was
removed from the VM and from the shared language tests.  This caused
those language tests to fail on analyzer (because analyzer still
requires the flag).

Also some tests that validated the non-supermixin behavior were deleted.

It looks like we are going to keep requiring the flag in analyzer until
the feature is implemented in dart2js (see
https://github.com/dart-lang/sdk/issues/24478#issuecomment-170054303).
So in order to ensure that the analyzer implementation continues to be
tested, we still need the flags in the tests.  We also need the old
tests that validate the non-supermixin behavior, since the analyzer
continues to implement that behavior when the "--supermixin" flag is
absent.

This CL does not introduce any new VM failures, because (a) the VM
ignores the "--supermixin" flag, so the tests in which the flag is being
reintroduced will still behave the same way on the VM, and (b) the tests
that validate non-supermixin behavior are disabled on the VM.
==========

to

==========
Restore old supermixin functionality to shared language tests.

In 451eaab71824d51d50a618f374a74bff578801f0 the "--supermixin" flag was
removed from the VM and from the shared language tests.  This caused
those language tests to fail on analyzer (because analyzer still
requires the flag).

Also some tests that validated the non-supermixin behavior were deleted.

It looks like we are going to keep requiring the flag in analyzer until
the feature is implemented in dart2js (see
https://github.com/dart-lang/sdk/issues/24478#issuecomment-170054303).
So in order to ensure that the analyzer implementation continues to be
tested, we still need the flags in the tests.  We also need the old
tests that validate the non-supermixin behavior, since the analyzer
continues to implement that behavior when the "--supermixin" flag is
absent.

This CL does not introduce any new VM failures, because (a) the VM
ignores the "--supermixin" flag, so the tests in which the flag is being
reintroduced will still behave the same way on the VM, and (b) the tests
that validate non-supermixin behavior are disabled on the VM.

R=brianwilkerson@google.com, regis@google.com

Committed:
https://github.com/dart-lang/sdk/commit/afc2c880a6080d83afa8af3247844791cee5ab29
==========

[Paul Berry, 2016-01-26 16:50:27]

Committed patchset #1 (id:1) manually as
afc2c880a6080d83afa8af3247844791cee5ab29 (presubmit successful).

[Paul Berry, 2016-01-26 16:50:31]

https://codereview.chromium.org/1635763003/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/1635763003/diff/1/tests/language/language.sta...
tests/language/language.status:11: mixin_illegal_superclass_test: Skip #
"--supermixin" functionality already switched on in VM
On 2016/01/26 01:42:59, regis wrote:
> Please, refer an issue so that we know when to remove these lines.

Done.