Introduce Queue-Based Notification Snackbars

chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java

Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java
index cde96c174e02fd202866f541ee2f140028bbdedf..e83a7627a961c5703d45d66b63e6896f9380606f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java
@@ -19,6 +19,18 @@ import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
  *           .setDuration(3000));
  */
 public class Snackbar {
+    /**
+     * Snackbars that are created as an immediate response to user's action. These snackbars are
+     * managed in a stack and will be swiped away altogether after timeout.
+     */
+    public static final int TYPE_ACTION = 0;
+
+    /**
+     * Snackbars that are for notification purposes. These snackbars are stored in a queue and thus
+     * are of lower priority, compared to {@link #TYPE_ACTION}. Notification snackbars are dismissed
+     * one by one.
+     */
+    public static final int TYPE_NOTIFICATION = 1;
 
     private SnackbarController mController;
     private CharSequence mText;
@@ -29,20 +41,23 @@ public class Snackbar {
     private boolean mSingleLine = true;
     private int mDurationMs;
     private Bitmap mProfileImage;
-    private boolean mForceDisplay = false;
+    private int mType;
 
     // Prevent instantiation.
     private Snackbar() {}
 
     /**
      * Creates and returns a snackbar to display the given text.
+     *
      * @param text The text to show on the snackbar.
      * @param controller The SnackbarController to receive callbacks about the snackbar's state.
+     * @param type Type of the snackbar. Either {@link #TYPE_ACTION} or {@link #TYPE_NOTIFICATION}.
      */
-    public static Snackbar make(CharSequence text, SnackbarController controller) {
+    public static Snackbar make(CharSequence text, SnackbarController controller, int type) {
         Snackbar s = new Snackbar();
         s.mText = text;
         s.mController = controller;
+        s.mType = type;
         return s;
     }
 
@@ -103,27 +118,6 @@ public class Snackbar {
         return this;
     }
 
-    /**
-     * Forces this snackbar to be shown when {@link #dismissAllSnackbars(SnackbarManager)} is called
-     * from a timeout. If {@link #showSnackbar(SnackbarManager)} is called while this snackbar is
-     * showing, the new snackbar will be added to the stack and this snackbar will not be
-     * overwritten.
-     */
-    public Snackbar setForceDisplay() {
-        mForceDisplay = true;
-        return this;
-    }
-
-    /**
-     * Returns true if this snackbar should still be shown when @link
-     * #dismissAllSnackbars(SnackbarManager)} is called from a timeout. If
-     * {@link #showSnackbar(SnackbarManager)} is called while this snackbar is showing, the new
-     * snackbar will be added to the stack and this snackbar will not be overwritten.
-     */
-    public boolean getForceDisplay() {
-        return mForceDisplay;
-    }
-
     SnackbarController getController() {
         return mController;
     }
@@ -165,4 +159,11 @@ public class Snackbar {
     Bitmap getProfileImage() {
         return mProfileImage;
     }
+
+    /**
+     * @return Whether the snackbar is of {@link #TYPE_ACTION}.
+     */
+    boolean isOnStack() {

[newt (away), 2016/01/27 02:13:40]

This class shouldn't both with details about stacks and queues; it should just
know about snackbar types. So, how about calling this method "isTypeAction()" or
just "getType()"

[Ian Wen, 2016/01/27 18:14:07]

Done.

+        return mType == TYPE_ACTION;
+    }
 }