Issue 163573003: Require the entire document-tree of an SVGImage to be single-origin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 163573003: Require the entire document-tree of an SVGImage to be single-origin (Closed)

Created:
6 years, 10 months ago by fs

Modified:
6 years, 10 months ago

Reviewers:
pdr., f(malita), Stephen Chennney

CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Require the entire document-tree to be single-origin for SVGImage SVGImage::currentFrameHasSingleSecurityOrigin only checks the first occurance of an <svg:image> or and <svg:feImage>, which meant that if the first such element had a benign reference, any later elements would be ignored. Also, since |node| can only ever match one of the tagnames, use a cascading 'if' where appropriate. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167097

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -6 lines)			Patch
A +	LayoutTests/canvas/feimage-with-foreignobject-taint-canvas-2.html	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	LayoutTests/canvas/feimage-with-foreignobject-taint-canvas-2-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/canvas/image-with-foreignobject-taint-canvas-2.html	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	LayoutTests/canvas/image-with-foreignobject-taint-canvas-2-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/canvas/resources/svg-with-multiple-feimage-one-with-foreignobject.svg	View	1 chunk	+8 lines, -2 lines	0 comments	Download
A	LayoutTests/canvas/resources/svg-with-multiple-images-one-with-foreignobject.svg	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/core/svg/graphics/SVGImage.cpp	View	1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/163573003/1

6 years, 10 months ago (2014-02-13 16:21:08 UTC) #4

Message was sent while issue was closed.

Change committed as 167097

Expand Messages | Collapse Messages