Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: pkg/analyzer_experimental/lib/src/error_formatter.dart

Issue 16357010: Basic dart^2 analyzer tests running. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer_experimental/lib/src/error_formatter.dart
diff --git a/pkg/analyzer_experimental/lib/src/error_formatter.dart b/pkg/analyzer_experimental/lib/src/error_formatter.dart
index 34d0fb4b2935c08eb4746e306868cfc6e85eebf7..dfe081e053410cbd9657a7e8cbc567f6d5e62b64 100644
--- a/pkg/analyzer_experimental/lib/src/error_formatter.dart
+++ b/pkg/analyzer_experimental/lib/src/error_formatter.dart
@@ -27,12 +27,6 @@ class ErrorFormatter {
ErrorFormatter(this.out, this.options);
- void startAnalysis() {
- if (!options.machineFormat) {
- out.writeln("Analyzing ${options.sourceFiles}...");
- }
- }
-
void formatErrors(List<AnalysisErrorInfo> errorInfos) {
var errors = new List<AnalysisError>();
var errorToLine = new Map<AnalysisError, LineInfo>();
@@ -122,13 +116,14 @@ class ErrorFormatter {
out.write('|');
out.write(length);
out.write('|');
- out.writeln(escapePipe(error.message));
+ out.write(escapePipe(error.message));
} else {
// [warning] 'foo' is not a... (/Users/.../tmp/foo.dart, line 1, col 2)
out.write('[${severity.displayName}] ${error.message} ');
out.write('(${source.fullName}');
out.write(', line ${location.lineNumber}, col ${location.columnNumber})');
}
+ out.write('\n');
Brian Wilkerson 2013/06/04 15:56:47 Does writeln produce platform specific end-of-line
scheglov 2013/06/04 16:08:52 Every implementation I see write \n, but may be th
}
static String escapePipe(String input) {
« no previous file with comments | « pkg/analyzer_experimental/lib/src/analyzer_impl.dart ('k') | pkg/analyzer_experimental/lib/src/generated/ast.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698