Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 16357005: Pass command line arguments through with --load-and-launch-app. (Closed)

Created:
7 years, 6 months ago by benwells
Modified:
7 years, 6 months ago
CC:
chromium-reviews, tfarina, Aaron Boodman, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Pass command line arguments through with --load-and-launch-app. This lets uninstalled unpacked apps be started via this flag and passed files to process. BUG=246510 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205503

Patch Set 1 #

Patch Set 2 : Clenup #

Total comments: 4

Patch Set 3 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -32 lines) Patch
M apps/app_load_service.h View 1 2 4 chunks +24 lines, -4 lines 0 comments Download
M apps/app_load_service.cc View 1 2 5 chunks +36 lines, -20 lines 0 comments Download
M apps/load_and_launch_browsertest.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 chunk +3 lines, -8 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/load_and_launch_file/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/load_and_launch_file/test.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
benwells
7 years, 6 months ago (2013-06-05 00:55:55 UTC) #1
koz (OOO until 15th September)
lgtm https://codereview.chromium.org/16357005/diff/5001/apps/app_load_service.h File apps/app_load_service.h (right): https://codereview.chromium.org/16357005/diff/5001/apps/app_load_service.h#newcode27 apps/app_load_service.h:27: RELOAD_LAUNCH, nit: I think it's fine to remove ...
7 years, 6 months ago (2013-06-05 08:34:11 UTC) #2
benwells
+sky for startup_browser_creator https://codereview.chromium.org/16357005/diff/5001/apps/app_load_service.h File apps/app_load_service.h (right): https://codereview.chromium.org/16357005/diff/5001/apps/app_load_service.h#newcode27 apps/app_load_service.h:27: RELOAD_LAUNCH, On 2013/06/05 08:34:11, koz wrote: ...
7 years, 6 months ago (2013-06-06 00:22:42 UTC) #3
sky
LGTM
7 years, 6 months ago (2013-06-06 16:06:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/16357005/14001
7 years, 6 months ago (2013-06-07 00:48:25 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=122789
7 years, 6 months ago (2013-06-07 02:17:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/16357005/14001
7 years, 6 months ago (2013-06-07 04:36:56 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-07 06:20:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/16357005/14001
7 years, 6 months ago (2013-06-11 04:50:17 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 12:20:24 UTC) #10
Message was sent while issue was closed.
Change committed as 205503

Powered by Google App Engine
This is Rietveld 408576698