Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2062)

Unified Diff: chrome/browser/ui/webui/settings/appearance_handler.cc

Issue 1635673003: MD Settings: Add helper method for responding to cr.sendWithPromise. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/appearance_handler.cc
diff --git a/chrome/browser/ui/webui/settings/appearance_handler.cc b/chrome/browser/ui/webui/settings/appearance_handler.cc
index 01ead427b727565e29cd6d59b3d5e53fd5230bdf..726d97aff5c34d41e4b5aa976017a4d60184718d 100644
--- a/chrome/browser/ui/webui/settings/appearance_handler.cc
+++ b/chrome/browser/ui/webui/settings/appearance_handler.cc
@@ -71,15 +71,12 @@ base::FundamentalValue AppearanceHandler::QueryResetThemeEnabledState() {
}
void AppearanceHandler::GetResetThemeEnabled(const base::ListValue* args) {
- CHECK_EQ(2U, args->GetSize());
-
- std::string callbackFn;
- CHECK(args->GetString(0, &callbackFn));
+ CHECK_EQ(1U, args->GetSize());
const base::Value* callbackId;
Dan Beam 2016/01/27 00:23:57 callback_id
dpapad 2016/01/27 00:45:23 Done.
- CHECK(args->Get(1, &callbackId));
+ CHECK(args->Get(0, &callbackId));
base::FundamentalValue enabled(QueryResetThemeEnabledState());
- web_ui()->CallJavascriptFunction(callbackFn, *callbackId, enabled);
+ CallJavascriptCallback(web_ui(), *callbackId, enabled);
}
} // namespace settings

Powered by Google App Engine
This is Rietveld 408576698