Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Side by Side Diff: chrome/browser/ui/webui/settings/md_settings_ui.cc

Issue 1635673003: MD Settings: Add helper method for responding to cr.sendWithPromise. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/md_settings_ui.h" 5 #include "chrome/browser/ui/webui/settings/md_settings_ui.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 22 matching lines...) Expand all
33 #endif // defined(OS_CHROMEOS) 33 #endif // defined(OS_CHROMEOS)
34 34
35 namespace settings { 35 namespace settings {
36 36
37 SettingsPageUIHandler::SettingsPageUIHandler() { 37 SettingsPageUIHandler::SettingsPageUIHandler() {
38 } 38 }
39 39
40 SettingsPageUIHandler::~SettingsPageUIHandler() { 40 SettingsPageUIHandler::~SettingsPageUIHandler() {
41 } 41 }
42 42
43 void SettingsPageUIHandler::CallJavascriptCallback(
44 content::WebUI* webui, const base::Value& callbackId,
45 const base::Value& response) {
46 // cr.webUIResponse is a global JS function exposed from cr.js.
47 webui->CallJavascriptFunction("cr.webUIResponse", callbackId, response);
Dan Beam 2016/01/27 00:23:57 why not just web_ui()?
dpapad 2016/01/27 00:45:23 Ah, fixed.
48 }
49
43 MdSettingsUI::MdSettingsUI(content::WebUI* web_ui) 50 MdSettingsUI::MdSettingsUI(content::WebUI* web_ui)
44 : content::WebUIController(web_ui) { 51 : content::WebUIController(web_ui) {
45 Profile* profile = Profile::FromWebUI(web_ui); 52 Profile* profile = Profile::FromWebUI(web_ui);
46 AddSettingsPageUIHandler(new AppearanceHandler(web_ui)); 53 AddSettingsPageUIHandler(new AppearanceHandler(web_ui));
47 AddSettingsPageUIHandler(new ClearBrowsingDataHandler(web_ui)); 54 AddSettingsPageUIHandler(new ClearBrowsingDataHandler(web_ui));
48 AddSettingsPageUIHandler(new DefaultBrowserHandler(web_ui)); 55 AddSettingsPageUIHandler(new DefaultBrowserHandler(web_ui));
49 AddSettingsPageUIHandler(new DownloadsHandler()); 56 AddSettingsPageUIHandler(new DownloadsHandler());
50 AddSettingsPageUIHandler(new FontHandler(web_ui)); 57 AddSettingsPageUIHandler(new FontHandler(web_ui));
51 AddSettingsPageUIHandler(new LanguagesHandler(web_ui)); 58 AddSettingsPageUIHandler(new LanguagesHandler(web_ui));
52 AddSettingsPageUIHandler(new PeopleHandler(profile)); 59 AddSettingsPageUIHandler(new PeopleHandler(profile));
(...skipping 28 matching lines...) Expand all
81 88
82 void MdSettingsUI::AddSettingsPageUIHandler( 89 void MdSettingsUI::AddSettingsPageUIHandler(
83 content::WebUIMessageHandler* handler_raw) { 90 content::WebUIMessageHandler* handler_raw) {
84 scoped_ptr<content::WebUIMessageHandler> handler(handler_raw); 91 scoped_ptr<content::WebUIMessageHandler> handler(handler_raw);
85 DCHECK(handler.get()); 92 DCHECK(handler.get());
86 93
87 web_ui()->AddMessageHandler(handler.release()); 94 web_ui()->AddMessageHandler(handler.release());
88 } 95 }
89 96
90 } // namespace settings 97 } // namespace settings
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698