Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1635663002: [Extensions] Fix override urls' visible urls (Closed)

Created:
4 years, 11 months ago by Devlin
Modified:
4 years, 11 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Fix override urls' visible urls When we override a URL like chrome://bookmarks by an extension, it maps it to the chrome-extension:// url, but should still display the chrome://bookmarks url in the omnibox. crrev.com/5fafa5aa3c2bde50f4f50511f134192147f86b55 changed the way prefs were read, so it broke this. Fix the breakage, and add a unittest so that it doesn't happen again. BUG=579389 Committed: https://crrev.com/2b7cf6ac0c8e1d6167a4925538fd11f41e1e0501 Cr-Commit-Position: refs/heads/master@{#371824}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -26 lines) Patch
M chrome/browser/extensions/extension_web_ui.cc View 1 chunk +12 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui_unittest.cc View 3 chunks +46 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Devlin
grr...there were no tests for the reverse lookup. :( (Now there are, though!)
4 years, 11 months ago (2016-01-25 21:54:51 UTC) #3
Finnur
Missed this yesterday. LGTM.
4 years, 11 months ago (2016-01-27 17:11:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635663002/20001
4 years, 11 months ago (2016-01-27 17:22:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 11 months ago (2016-01-27 18:23:59 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 18:25:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b7cf6ac0c8e1d6167a4925538fd11f41e1e0501
Cr-Commit-Position: refs/heads/master@{#371824}

Powered by Google App Engine
This is Rietveld 408576698