mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl - Issue 1635613002: [mojo-bindings] Support reuse of native enum classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

Issue 1635613002: [mojo-bindings] Support reuse of native enum classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove now-unnecessary enum casts Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/mus/public/interfaces/compositor_frame.mojom ('K') | « mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl ('k') | mojo/public/tools/bindings/generators/mojom_cpp_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

index ebc6048c29253d881deb160df3c3e8209412c8a7..0285dac0614fb1dcaf313f602cef4644d31fa97f 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

@@ -149,11 +149,14 @@

if ({{input}}->header_.version < {{pf.min_version}})

break;

{%- endif %}

-{%- if kind|is_native_only_kind %}

+{%- if kind|is_native_only_kind and kind|is_struct_kind %}

if (!DeserializeNative_(

{{input}}->{{name}}.ptr, &{{output_field}}, {{context}})) {

{{success}} = false;

}

+{%- elif kind|is_native_only_kind and kind|is_enum_kind %}

+ {{output_field}} = static_cast<{{kind|cpp_wrapper_type}}>(

+ {{input}}->{{name}});

{%- elif kind|is_typemapped_kind %}

if (!{{kind|get_name_for_kind}}_SerializerTraits_<{{kind|cpp_wrapper_type}}>

::Deserialize(