mojo/public/tools/bindings/pylib/mojom/parse/ast.py - Issue 1635613002: [mojo-bindings] Support reuse of native enum classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/pylib/mojom/parse/ast.py

Issue 1635613002: [mojo-bindings] Support reuse of native enum classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix more missing public_deps Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/pylib/mojom/generate/data.py ('k') | mojo/public/tools/bindings/pylib/mojom/parse/parser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/pylib/mojom/parse/ast.py

diff --git a/mojo/public/tools/bindings/pylib/mojom/parse/ast.py b/mojo/public/tools/bindings/pylib/mojom/parse/ast.py

index 6473b02b6ba292bd963d6dd9163c7db57b9348c3..9ef256ceaead3d12cad8cc5797f73d430ab41795 100644

--- a/mojo/public/tools/bindings/pylib/mojom/parse/ast.py

+++ b/mojo/public/tools/bindings/pylib/mojom/parse/ast.py

@@ -138,7 +138,7 @@ class Enum(Definition):

def __init__(self, name, attribute_list, enum_value_list, **kwargs):

assert attribute_list is None or isinstance(attribute_list, AttributeList)

- assert isinstance(enum_value_list, EnumValueList)

+ assert isinstance(enum_value_list, EnumValueList) or enum_value_list is None

super(Enum, self).__init__(name, **kwargs)

self.attribute_list = attribute_list

self.enum_value_list = enum_value_list

« no previous file with comments | « mojo/public/tools/bindings/pylib/mojom/generate/data.py ('k') | mojo/public/tools/bindings/pylib/mojom/parse/parser.py » ('j') | no next file with comments »