mojo/public/tools/bindings/mojom.gni - Issue 1635613002: [mojo-bindings] Support reuse of native enum classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/mojom.gni

Issue 1635613002: [mojo-bindings] Support reuse of native enum classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix more missing public_deps Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/mojom_cpp_generator.py ('k') | mojo/public/tools/bindings/pylib/mojom/generate/data.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/mojom.gni

diff --git a/mojo/public/tools/bindings/mojom.gni b/mojo/public/tools/bindings/mojom.gni

index 6e2a62a8aa0fc4c8102bdd9395d6f0b7ff541ca5..deee35865dd87bb0ca1feab17f9f0448e86dd392 100644

--- a/mojo/public/tools/bindings/mojom.gni

+++ b/mojo/public/tools/bindings/mojom.gni

@@ -61,6 +61,10 @@ mojom_generator_sources = [

# A variant name to apply to generated bindings. Variant influences

# generated source filenames as wells the symbols they define.

+# cpp_only (optional)

+# If true, only C++ bindings will be generated. This defaults to false

+# unless |variant| is specified.

# testonly (optional)

# visibility (optional)

@@ -73,6 +77,9 @@ template("mojom") {

cpp_sources_suffix = "cpp_sources"

cpp_sources_target_name = "${target_name}_${cpp_sources_suffix}"

cpp_only = false

+ if (defined(invoker.cpp_only)) {

+ cpp_only = invoker.cpp_only

+ }

if (defined(invoker.sources)) {

if (defined(invoker.variant)) {

variant = invoker.variant