Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1650)

Unified Diff: mojo/public/tools/bindings/pylib/mojom/generate/data.py

Issue 1635613002: [mojo-bindings] Support reuse of native enum classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: do not generate validators for native-only enums Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/pylib/mojom/generate/data.py
diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/data.py b/mojo/public/tools/bindings/pylib/mojom/generate/data.py
index 60ae1e0d4c55e3df67b6db1c6cfc508696505527..6fc77ae9e1c951081b5e3ea6ea47912244421b50 100644
--- a/mojo/public/tools/bindings/pylib/mojom/generate/data.py
+++ b/mojo/public/tools/bindings/pylib/mojom/generate/data.py
@@ -397,6 +397,7 @@ def ResolveNumericEnumValues(enum_fields):
def EnumFromData(module, data, parent_kind):
enum = mojom.Enum(module=module)
enum.name = data['name']
+ enum.native_only = data['native_only']
name = enum.name
if parent_kind:
name = parent_kind.name + '.' + name
@@ -404,11 +405,18 @@ def EnumFromData(module, data, parent_kind):
enum.parent_kind = parent_kind
enum.fields = map(
lambda field: EnumFieldFromData(module, enum, field, parent_kind),
- data['fields'])
+ data['fields']) if not enum.native_only else []
enum.attributes = data.get('attributes')
ResolveNumericEnumValues(enum.fields)
module.kinds[enum.spec] = enum
+
+ # Enforce that a [native=True] attribute is set to make native-only enum
+ # declarations more explicit.
+ if enum.native_only:
+ if not enum.attributes or not enum.attributes.get('native', False):
+ raise Exception("Native-only enum declarations must include a " +
+ "native=True attribute.")
return enum
def ConstantFromData(module, data, parent_kind):

Powered by Google App Engine
This is Rietveld 408576698