[mojo-bindings] Support reuse of native enum classes

mojo/public/tools/bindings/generators/mojom_cpp_generator.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generates C++ source files from a mojom.Module."""
 
 import mojom.generate.generator as generator
 import mojom.generate.module as mojom
 import mojom.generate.pack as pack
 from mojom.generate.template_expander import UseJinja
@@ skipping 43 matching lines @@
   if field.default:
     if mojom.IsStructKind(field.kind):
       assert field.default == "default"
       return "%s::New()" % GetNameForKind(field.kind)
     return ExpressionToText(field.default, kind=field.kind)
   return ""
 
 def NamespaceToArray(namespace):
   return namespace.split(".") if namespace else []
 
+def IsNativeStructKind(kind):
+  return mojom.IsStructKind(kind) and kind.native_only
+
+def IsNativeEnumKind(kind):
+  return mojom.IsEnumKind(kind) and kind.native_only
+
 def GetNamePartsForKind(kind, add_same_module_namespaces, internal):
   def MapKindName_(kind):
     if not internal:
       return kind.name
-    if mojom.IsStructKind(kind) and kind.native_only:
+    if IsNativeStructKind(kind):
       return "mojo::Array_Data<uint8_t>"
     if (mojom.IsStructKind(kind) or mojom.IsUnionKind(kind) or
         mojom.IsInterfaceKind(kind) or mojom.IsEnumKind(kind)):
       return kind.name + "_Data"
     return kind.name
 
   parts = []
   if kind.imported_from:
     parts.extend(NamespaceToArray(kind.imported_from["namespace"]))
   elif hasattr(kind, "module") and add_same_module_namespaces:
@@ skipping 16 matching lines @@
   return "::".join(parts)
 
 def GetFullMojomNameForKind(kind):
   parts = GetNamePartsForKind(kind, True, False)
   return ".".join(parts)
 
 def IsTypemappedKind(kind):
   return hasattr(kind, "name") and \
       GetFullMojomNameForKind(kind) in _current_typemap
 
-def IsNativeOnlyKind(kind):
-  return mojom.IsStructKind(kind) and kind.native_only
-
 def GetNativeTypeName(typemapped_kind):
   return _current_typemap[GetFullMojomNameForKind(typemapped_kind)]["typename"]
 
 def DoesKindSupportEquality(kind):
   if IsTypemappedKind(kind):
     return False
-  if mojom.IsStructKind(kind) and kind.native_only:
+  if IsNativeStructKind(kind):
     return False
   if mojom.IsArrayKind(kind):
     return DoesKindSupportEquality(kind.kind)
   if mojom.IsMapKind(kind):
     return DoesKindSupportEquality(kind.value_kind)
   return True
 
 def GetCppType(kind):
-  if mojom.IsStructKind(kind) and kind.native_only:
+  if IsNativeStructKind(kind):
     # A native-only type is just a blob of bytes.
     return "mojo::internal::Array_Data<uint8_t>*"
   if mojom.IsArrayKind(kind):
     return "mojo::internal::Array_Data<%s>*" % GetCppType(kind.kind)
   if mojom.IsMapKind(kind):
     return "mojo::internal::Map_Data<%s, %s>*" % (
       GetCppType(kind.key_kind), GetCppType(kind.value_kind))
   if mojom.IsStructKind(kind):
     return "%s*" % GetNameForKind(kind, internal=True)
   if mojom.IsUnionKind(kind):
@@ skipping 11 matching lines @@
   if mojom.IsStringKind(kind):
     return "mojo::internal::String_Data*"
   return _kind_to_cpp_type[kind]
 
 def GetCppPodType(kind):
   if mojom.IsStringKind(kind):
     return "char*"
   return _kind_to_cpp_type[kind]
 
 def GetCppArrayArgWrapperType(kind):
-  if mojom.IsStructKind(kind) and kind.native_only:
+  if IsNativeStructKind(kind):
     if IsTypemappedKind(kind):
       return GetNativeTypeName(kind)
-    else:
-      # Without a relevant typemap to apply, a native-only struct can only be
-      # exposed as a blob of bytes.
-      return "mojo::Array<uint8_t>"
-  if IsTypemappedKind(kind):
+    # Without a relevant typemap to apply, a native-only struct can only be
+    # exposed as a blob of bytes.
+    return "mojo::Array<uint8_t>"
+  if mojom.IsStructKind(kind) and IsTypemappedKind(kind):
     raise Exception(
         "Cannot serialize containers of non-native typemapped structs yet!")
+  if IsNativeEnumKind(kind):
+    assert IsTypemappedKind(kind)
+    return GetNativeTypeName(kind)
   if mojom.IsEnumKind(kind):
     return GetNameForKind(kind)
   if mojom.IsStructKind(kind) or mojom.IsUnionKind(kind):
     return "%sPtr" % GetNameForKind(kind)
   if mojom.IsArrayKind(kind):
     return "mojo::Array<%s> " % GetCppArrayArgWrapperType(kind.kind)
   if mojom.IsMapKind(kind):
     return "mojo::Map<%s, %s> " % (GetCppArrayArgWrapperType(kind.key_kind),
                                    GetCppArrayArgWrapperType(kind.value_kind))
   if mojom.IsInterfaceKind(kind):
@@ skipping 13 matching lines @@
     return "mojo::ScopedDataPipeConsumerHandle"
   if mojom.IsDataPipeProducerKind(kind):
     return "mojo::ScopedDataPipeProducerHandle"
   if mojom.IsMessagePipeKind(kind):
     return "mojo::ScopedMessagePipeHandle"
   if mojom.IsSharedBufferKind(kind):
     return "mojo::ScopedSharedBufferHandle"
   return _kind_to_cpp_type[kind]
 
 def GetCppResultWrapperType(kind):
-  if IsTypemappedKind(kind):
+  if mojom.IsStructKind(kind) and IsTypemappedKind(kind):
     return "const %s&" % GetNativeTypeName(kind)
-  if mojom.IsStructKind(kind) and kind.native_only:
+  if IsNativeStructKind(kind):
     return "mojo::Array<uint8_t>"
+  if IsNativeEnumKind(kind):
+    return GetNativeTypeName(kind)
   if mojom.IsEnumKind(kind):
     return GetNameForKind(kind)
   if mojom.IsStructKind(kind) or mojom.IsUnionKind(kind):
     return "%sPtr" % GetNameForKind(kind)
   if mojom.IsArrayKind(kind):
     return "mojo::Array<%s>" % GetCppArrayArgWrapperType(kind.kind)
   if mojom.IsMapKind(kind):
     return "mojo::Map<%s, %s>" % (GetCppArrayArgWrapperType(kind.key_kind),
                                   GetCppArrayArgWrapperType(kind.value_kind))
   if mojom.IsInterfaceKind(kind):
@@ skipping 20 matching lines @@
   # revisit strategy used below for emitting a useful error message when an
   # undefined identifier is referenced.
   val =  _kind_to_cpp_type.get(kind)
   if (val is not None):
     return val
   raise Exception("Unrecognized kind %s" % kind.spec)
 
 def GetCppWrapperType(kind):
   if IsTypemappedKind(kind):
     return GetNativeTypeName(kind)
-  if mojom.IsStructKind(kind) and kind.native_only:
+  assert not IsNativeEnumKind(kind)
+  if IsNativeStructKind(kind):
     return "mojo::Array<uint8_t>"
   if mojom.IsEnumKind(kind):
     return GetNameForKind(kind)
   if mojom.IsStructKind(kind) or mojom.IsUnionKind(kind):
     return "%sPtr" % GetNameForKind(kind)
   if mojom.IsArrayKind(kind):
     return "mojo::Array<%s>" % GetCppArrayArgWrapperType(kind.kind)
   if mojom.IsMapKind(kind):
     return "mojo::Map<%s, %s>" % (GetCppArrayArgWrapperType(kind.key_kind),
                                   GetCppArrayArgWrapperType(kind.value_kind))
@@ skipping 13 matching lines @@
     return "mojo::ScopedDataPipeConsumerHandle"
   if mojom.IsDataPipeProducerKind(kind):
     return "mojo::ScopedDataPipeProducerHandle"
   if mojom.IsMessagePipeKind(kind):
     return "mojo::ScopedMessagePipeHandle"
   if mojom.IsSharedBufferKind(kind):
     return "mojo::ScopedSharedBufferHandle"
   return _kind_to_cpp_type[kind]
 
 def GetCppConstWrapperType(kind):
-  if IsTypemappedKind(kind):
+  if mojom.IsStructKind(kind) and IsTypemappedKind(kind):
     return "const %s&" % GetNativeTypeName(kind)
-  if mojom.IsStructKind(kind) and kind.native_only:
+  if IsNativeStructKind(kind):
     return "mojo::Array<uint8_t>"
+  if IsNativeEnumKind(kind):
+    assert IsTypemappedKind(kind)
+    return GetNativeTypeName(kind)
   if mojom.IsStructKind(kind) or mojom.IsUnionKind(kind):
     return "%sPtr" % GetNameForKind(kind)
   if mojom.IsArrayKind(kind):
     return "mojo::Array<%s>" % GetCppArrayArgWrapperType(kind.kind)
   if mojom.IsMapKind(kind):
     return "mojo::Map<%s, %s>" % (GetCppArrayArgWrapperType(kind.key_kind),
                                   GetCppArrayArgWrapperType(kind.value_kind))
   if mojom.IsInterfaceKind(kind):
     return "%sPtr" % GetNameForKind(kind)
   if mojom.IsInterfaceRequestKind(kind):
@@ skipping 14 matching lines @@
     return "mojo::ScopedDataPipeProducerHandle"
   if mojom.IsMessagePipeKind(kind):
     return "mojo::ScopedMessagePipeHandle"
   if mojom.IsSharedBufferKind(kind):
     return "mojo::ScopedSharedBufferHandle"
   if not kind in _kind_to_cpp_type:
     print "missing:", kind.spec
   return _kind_to_cpp_type[kind]
 
 def GetCppFieldType(kind):
-  if mojom.IsStructKind(kind) and kind.native_only:
+  if IsNativeStructKind(kind):
     return "mojo::internal::ArrayPointer<uint8_t>"
   if mojom.IsStructKind(kind):
     return ("mojo::internal::StructPointer<%s>" %
         GetNameForKind(kind, internal=True))
   if mojom.IsUnionKind(kind):
     return "%s" % GetNameForKind(kind, internal=True)
   if mojom.IsArrayKind(kind):
     return "mojo::internal::ArrayPointer<%s>" % GetCppType(kind.kind)
   if mojom.IsMapKind(kind):
     return ("mojo::internal::StructPointer<mojo::internal::Map_Data<%s, %s>>" %
@@ skipping 145 matching lines @@
     "get_pad": pack.GetPad,
     "get_qualified_name_for_kind": GetQualifiedNameForKind,
     "has_callbacks": mojom.HasCallbacks,
     "should_inline": ShouldInlineStruct,
     "should_inline_union": ShouldInlineUnion,
     "is_array_kind": mojom.IsArrayKind,
     "is_cloneable_kind": mojom.IsCloneableKind,
     "is_enum_kind": mojom.IsEnumKind,
     "is_integral_kind": mojom.IsIntegralKind,
     "is_move_only_kind": mojom.IsMoveOnlyKind,
-    "is_native_only_kind": IsNativeOnlyKind,
+    "is_native_enum_kind": IsNativeEnumKind,
+    "is_native_struct_kind": IsNativeStructKind,
     "is_any_handle_kind": mojom.IsAnyHandleKind,
     "is_interface_kind": mojom.IsInterfaceKind,
     "is_interface_request_kind": mojom.IsInterfaceRequestKind,
     "is_associated_interface_kind": mojom.IsAssociatedInterfaceKind,
     "is_associated_interface_request_kind":
         mojom.IsAssociatedInterfaceRequestKind,
     "is_associated_kind": mojom.IsAssociatedKind,
     "is_map_kind": mojom.IsMapKind,
     "is_nullable_kind": mojom.IsNullableKind,
     "is_object_kind": mojom.IsObjectKind,
@@ skipping 52 matching lines @@
   def GenerateFiles(self, args):
     global _current_typemap
     _current_typemap = self.typemap
     suffix = "-%s" % self.variant if self.variant else ""
     self.Write(self.GenerateModuleHeader(),
         self.MatchMojomFilePath("%s%s.h" % (self.module.name, suffix)))
     self.Write(self.GenerateModuleInternalHeader(),
         self.MatchMojomFilePath("%s%s-internal.h" % (self.module.name, suffix)))
     self.Write(self.GenerateModuleSource(),
         self.MatchMojomFilePath("%s%s.cc" % (self.module.name, suffix)))