Issue 16356006: change impl to explicitly store length as u32, rather than size_t, so we keep a packed struct on 64…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16356006: change impl to explicitly store length as u32, rather than size_t, so we keep a packed struct on 64… (Closed)

Created:
7 years, 6 months ago by reed1

Modified:
7 years, 6 months ago

Reviewers:
bungeman-skia

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

change impl to explicitly store length as u32, rather than size_t, so we keep a packed struct on 64bit machines BUG= Committed: https://code.google.com/p/skia/source/detail?r=9436

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -6 lines)			Patch
	M	include/core/SkString.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/core/SkString.cpp	View		7 chunks	+36 lines, -5 lines	1 comment	Download

Total messages: 3 (0 generated)

bungeman-skia

The change seems to do what it claims it does, if you think it's work ...

7 years, 6 months ago (2013-06-04 15:30:45 UTC) #2

reed1

7 years, 6 months ago (2013-06-04 20:37:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r9436 (presubmit successful).