third_party/WebKit/Source/core/experiments/ExperimentsTest.cpp - Issue 1635593004: Rename Experimental Framework classes and concepts

Unified Diff: third_party/WebKit/Source/core/experiments/ExperimentsTest.cpp

Issue 1635593004: Rename Experimental Framework classes and concepts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/experiments/Experiments.cpp ('k') | third_party/WebKit/Source/core/experiments/testing/InternalsFrobulate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/experiments/ExperimentsTest.cpp

diff --git a/third_party/WebKit/Source/core/experiments/ExperimentsTest.cpp b/third_party/WebKit/Source/core/experiments/ExperimentsTest.cpp

deleted file mode 100644

index aa90cf64940656f484d1b103cbeda0ac9d934187..0000000000000000000000000000000000000000

--- a/third_party/WebKit/Source/core/experiments/ExperimentsTest.cpp

+++ /dev/null

@@ -1,234 +0,0 @@

-// Use of this source code is governed by a BSD-style license that can be

-// found in the LICENSE file.

-#include "core/experiments/Experiments.h"

-#include "core/HTMLNames.h"

-#include "core/dom/DOMException.h"

-#include "core/dom/ExceptionCode.h"

-#include "core/frame/FrameView.h"

-#include "core/html/HTMLDocument.h"

-#include "core/html/HTMLHeadElement.h"

-#include "core/html/HTMLMetaElement.h"

-#include "core/testing/DummyPageHolder.h"

-#include "platform/weborigin/KURL.h"

-#include "platform/weborigin/SecurityOrigin.h"

-#include "public/platform/WebApiKeyValidator.h"

-#include "testing/gtest/include/gtest/gtest.h"

-namespace blink {

-namespace {

-const char kNonExistingAPIName[] = "This API does not exist";

-const char kFrobulateAPIName[] = "Frobulate";

-const char kFrobulateEnabledOrigin[] = "https://www.example.com";

-const char kFrobulateEnabledOriginUnsecure[] = "http://www.example.com";

-// API Key that will appear valid.

-const char kGoodAPIKey[] = "AnySignatureWillDo|https://www.example.com|Frobulate|2000000000";

-class MockApiKeyValidator : public WebApiKeyValidator {

-public:

- MockApiKeyValidator()

- : m_response(false)

- , m_callCount(0)

- {

- }

- ~MockApiKeyValidator() override {}

- // blink::WebApiKeyValidator implementation

- bool validateApiKey(const blink::WebString& apiKey, const blink::WebString& origin, const blink::WebString& apiName) override

- {

- m_callCount++;

- return m_response;

- }

- // Useful methods for controlling the validator

- void setResponse(bool response)

- {

- m_response = response;

- }

- void reset()

- {

- m_response = false;

- m_callCount = 0;

- }

- int callCount()

- {

- return m_callCount;

- }

-private:

- bool m_response;

- int m_callCount;

- DISALLOW_COPY_AND_ASSIGN(MockApiKeyValidator);

-};

-} // namespace

-class ExperimentsTest : public ::testing::Test {

-protected:

- ExperimentsTest()

- : m_page(DummyPageHolder::create())

- , m_frameworkWasEnabled(RuntimeEnabledFeatures::experimentalFrameworkEnabled())

- , m_apiKeyValidator(adoptPtr(new MockApiKeyValidator()))

- {

- if (!RuntimeEnabledFeatures::experimentalFrameworkEnabled()) {

- RuntimeEnabledFeatures::setExperimentalFrameworkEnabled(true);

- }

- ~ExperimentsTest()

- {

- if (!m_frameworkWasEnabled) {

- RuntimeEnabledFeatures::setExperimentalFrameworkEnabled(false);

- }

- m_page.clear();

- }

- void SetUp() override

- {

- m_document = toHTMLDocument(&m_page->document());

- setInnerHTML(

- "<html>"

- "<head>"

- "</head>"

- "<body>"

- "</body>"

- "</html>");

- }

- ExecutionContext* executionContext() { return &(m_page->document()); }

- MockApiKeyValidator* apiKeyValidator() { return m_apiKeyValidator.get(); }

- HTMLDocument& document() const { return *m_document; }

- void setPageOrigin(const String& origin)

- {

- KURL pageURL(ParsedURLString, origin);

- RefPtr<SecurityOrigin> pageOrigin = SecurityOrigin::create(pageURL);

- m_page->document().updateSecurityOrigin(pageOrigin);

- }

- void setInnerHTML(const char* htmlContent)

- {

- document().documentElement()->setInnerHTML(String::fromUTF8(htmlContent), ASSERT_NO_EXCEPTION);

- document().view()->updateAllLifecyclePhases();

- }

- void addApiKey(const String& keyValue)

- {

- HTMLElement* head = document().head();

- ASSERT_TRUE(head);

- RefPtrWillBeRawPtr<HTMLMetaElement> meta = HTMLMetaElement::create(document());

- meta->setAttribute(HTMLNames::nameAttr, "api-experiments");

- AtomicString value(keyValue);

- meta->setAttribute(HTMLNames::contentAttr, value);

- head->appendChild(meta.release());

- }

- bool isApiEnabled(const String& origin, const String& apiName, const String& apiKeyValue, String* errorMessage)

- {

- setPageOrigin(origin);

- addApiKey(apiKeyValue);

- return Experiments::isApiEnabled(executionContext(), apiName, errorMessage, apiKeyValidator());

- }

- bool isApiEnabledWithoutErrorMessage(const String& origin, const String& apiName, const char* apiKeyValue)

- {

- return isApiEnabled(origin, apiName, apiKeyValue, nullptr);

- }

-private:

- OwnPtr<DummyPageHolder> m_page;

- RefPtrWillBePersistent<HTMLDocument> m_document;

- const bool m_frameworkWasEnabled;

- OwnPtr<MockApiKeyValidator> m_apiKeyValidator;

-};

-TEST_F(ExperimentsTest, EnabledNonExistingAPI)

- String errorMessage;

- bool isNonExistingApiEnabled = isApiEnabled(kFrobulateEnabledOrigin,

- kNonExistingAPIName,

- kGoodAPIKey,

- &errorMessage);

- EXPECT_FALSE(isNonExistingApiEnabled);

- EXPECT_EQ(("The provided key(s) are not valid for the 'This API does not exist' API."), errorMessage);

-TEST_F(ExperimentsTest, EnabledNonExistingAPIWithoutErrorMessage)

- bool isNonExistingApiEnabled = isApiEnabledWithoutErrorMessage(

- kFrobulateEnabledOrigin,

- kNonExistingAPIName,

- kGoodAPIKey);

- EXPECT_FALSE(isNonExistingApiEnabled);

-// The API should be enabled if a valid key for the origin is provided

-TEST_F(ExperimentsTest, EnabledSecureRegisteredOrigin)

- String errorMessage;

- apiKeyValidator()->setResponse(true);

- bool isOriginEnabled = isApiEnabled(kFrobulateEnabledOrigin,

- kFrobulateAPIName,

- kGoodAPIKey,

- &errorMessage);

- EXPECT_TRUE(isOriginEnabled);

- EXPECT_TRUE(errorMessage.isEmpty()) << "Message should be empty, was: " << errorMessage;

- EXPECT_EQ(1, apiKeyValidator()->callCount());

-// ... but if the browser says it's invalid for any reason, that's enough to

-// reject.

-TEST_F(ExperimentsTest, InvalidKeyResponseFromPlatform)

- String errorMessage;

- apiKeyValidator()->setResponse(false);

- bool isOriginEnabled = isApiEnabled(kFrobulateEnabledOrigin,

- kFrobulateAPIName,

- kGoodAPIKey,

- &errorMessage);

- EXPECT_FALSE(isOriginEnabled);

- EXPECT_EQ(("The provided key(s) are not valid for the 'Frobulate' API."), errorMessage);

- EXPECT_EQ(1, apiKeyValidator()->callCount());

-TEST_F(ExperimentsTest, EnabledSecureRegisteredOriginWithoutErrorMessage)

- apiKeyValidator()->setResponse(true);

- bool isOriginEnabled = isApiEnabledWithoutErrorMessage(

- kFrobulateEnabledOrigin,

- kFrobulateAPIName,

- kGoodAPIKey);

- EXPECT_TRUE(isOriginEnabled);

- EXPECT_EQ(1, apiKeyValidator()->callCount());

-// The API should not be enabled if the origin is unsecure, even if a valid

-// key for the origin is provided

-TEST_F(ExperimentsTest, EnabledNonSecureRegisteredOrigin)

- String errorMessage;

- bool isOriginEnabled = isApiEnabled(kFrobulateEnabledOriginUnsecure,

- kFrobulateAPIName,

- kGoodAPIKey,

- &errorMessage);

- EXPECT_FALSE(isOriginEnabled);

- EXPECT_TRUE(errorMessage.contains("secure origin")) << "Message should indicate only secure origins are allowed, was: " << errorMessage;

- EXPECT_EQ(0, apiKeyValidator()->callCount());

-TEST_F(ExperimentsTest, DisabledException)

- DOMException* disabledException = Experiments::createApiDisabledException(kNonExistingAPIName);

- ASSERT_TRUE(disabledException) << "An exception should have been created";

- EXPECT_EQ(DOMException::getErrorName(NotSupportedError), disabledException->name());

- EXPECT_TRUE(disabledException->message().contains(kNonExistingAPIName)) << "Message should contain the API name, was: " << disabledException->message();

-} // namespace blink