Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1635553002: [Interpreter] Add native function literal support. (Closed)

Created:
4 years, 11 months ago by rmcilroy
Modified:
4 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add native function literal support. Adds support for calling native function literals. Moves the logic for building the native function's SharedFunctionInfo out of full-codegen into compiler.cc to allow it to be shared between fullcodegen and Ignition. BUG=v8:4686 LOG=N Committed: https://crrev.com/befe61fa3e09a0121e677f8d4c37c181dfe4cbb7 Cr-Commit-Position: refs/heads/master@{#33510}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Add back some skips for Arm64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -138 lines) Patch
M src/compiler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -28 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +5 lines, -1 line 0 comments Download
M test/cctest/cctest.status View 1 2 3 chunks +1 line, -10 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 14 chunks +3 lines, -99 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
rmcilroy
As discussed, this adds native function literal support. I've not added explicit interpreter tests since ...
4 years, 11 months ago (2016-01-25 17:28:17 UTC) #2
Michael Starzinger
LGTM.
4 years, 11 months ago (2016-01-25 17:40:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635553002/1
4 years, 11 months ago (2016-01-25 17:43:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/12294) v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 11 months ago (2016-01-25 17:45:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635553002/20001
4 years, 11 months ago (2016-01-26 10:39:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/14432)
4 years, 11 months ago (2016-01-26 11:00:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635553002/40001
4 years, 11 months ago (2016-01-26 11:09:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635553002/40001
4 years, 11 months ago (2016-01-26 11:17:12 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-26 11:30:34 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 11:30:54 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/befe61fa3e09a0121e677f8d4c37c181dfe4cbb7
Cr-Commit-Position: refs/heads/master@{#33510}

Powered by Google App Engine
This is Rietveld 408576698