Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1635533003: Remove warning for inherited noSuchMethod. (Closed)

Created:
4 years, 11 months ago by Johnni Winther
Modified:
4 years, 11 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove warning for inherited noSuchMethod. Closes #25580 R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/735e0e60f816388de1931a45f721f5cc509bc12e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase + update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
M pkg/compiler/lib/src/resolution/class_members.dart View 2 chunks +8 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/override_inheritance_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/proxy_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/language/proxy4_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A tests/language/proxy5_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
https://codereview.chromium.org/1635533003/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1635533003/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode1234 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:1234: List<ast.Node> switchCases = node.cases.nodes.toList(); Type assertion failure in checked ...
4 years, 11 months ago (2016-01-26 10:53:49 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1635533003/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1635533003/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode1234 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:1234: List<ast.Node> switchCases = node.cases.nodes.toList(); This was fixed in ...
4 years, 11 months ago (2016-01-26 11:43:07 UTC) #3
Johnni Winther
4 years, 11 months ago (2016-01-26 12:41:59 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
735e0e60f816388de1931a45f721f5cc509bc12e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698