Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1635373002: [Reland] [Android] Set enable_remoting=true by default (Closed)

Created:
4 years, 10 months ago by pkotwicz
Modified:
4 years, 10 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] [Android] Set enable_remoting=true by default We set enable_remoting=true in the command line on the official builders. Set enable_remoting=true as the default on Chromium as well. BUG=544298 R=lambroslambrou TBR=dpranke Committed: https://crrev.com/a3ca9351c2e2bb5855c67c7c582b2578c83e67ee Cr-Commit-Position: refs/heads/master@{#371834}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M build/config/features.gni View 1 chunk +1 line, -1 line 0 comments Download
M remoting/android/BUILD.gn View 1 chunk +13 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
pkotwicz
lambroslambrou@ can you please take a look? Changes to remoting/android/BUILD.gn are new since the original ...
4 years, 10 months ago (2016-01-27 03:24:53 UTC) #4
Lambros
lgtm, thanks! I tested this patch locally and the Cardboard build works fine (I fixed ...
4 years, 10 months ago (2016-01-27 18:20:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635373002/40001
4 years, 10 months ago (2016-01-27 18:23:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 10 months ago (2016-01-27 19:07:33 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 19:08:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3ca9351c2e2bb5855c67c7c582b2578c83e67ee
Cr-Commit-Position: refs/heads/master@{#371834}

Powered by Google App Engine
This is Rietveld 408576698