Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1635323002: [SVG] Fix SVGPathBuilder subpath point tracking (Closed)

Created:
4 years, 11 months ago by f(malita)
Modified:
4 years, 11 months ago
Reviewers:
pdr., fs
CC:
fs, blink-reviews, chromium-reviews, krit, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SVG] Fix SVGPathBuilder subpath point tracking http://crrev.com/1623073003 introduced a bug where moveTos only update the subpath point when immediately following a closePath. This is incorrect: moveTos should always update the subpath point. BUG=581451 R=fs@opera.com,pdr@chromium.org Committed: https://crrev.com/fc36ae93c0148e853089729b6e2941d77ce30037 Cr-Commit-Position: refs/heads/master@{#371783}

Patch Set 1 #

Patch Set 2 : specific m_lastCommand initializer no longer required #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
A third_party/WebKit/LayoutTests/svg/custom/path-multiple-movetos.svg View 1 chunk +21 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/custom/path-multiple-movetos-expected.svg View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathBuilder.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathBuilder.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
f(malita)
4 years, 11 months ago (2016-01-27 02:01:56 UTC) #1
pdr.
LGTM
4 years, 11 months ago (2016-01-27 02:05:23 UTC) #2
fs
LGTM Also drop the comment for m_lastCommand in the constructor?
4 years, 11 months ago (2016-01-27 08:51:35 UTC) #3
f(malita)
On 2016/01/27 08:51:35, fs wrote: > Also drop the comment for m_lastCommand in the constructor? ...
4 years, 11 months ago (2016-01-27 13:19:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635323002/20001
4 years, 11 months ago (2016-01-27 13:20:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-27 14:34:49 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 14:35:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fc36ae93c0148e853089729b6e2941d77ce30037
Cr-Commit-Position: refs/heads/master@{#371783}

Powered by Google App Engine
This is Rietveld 408576698