Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 16353004: Add myself to Source/bindings/OWNERS (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, lgombos
Visibility:
Public.

Description

Add myself to Source/bindings/OWNERS NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152203

Patch Set 1 #

Total comments: 1

Patch Set 2 : Alphabetize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/bindings/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-10 06:47:23 UTC) #1
haraken
Given your fantastic IDL changes, LGTM.
7 years, 6 months ago (2013-06-10 06:48:21 UTC) #2
abarth-chromium
https://codereview.chromium.org/16353004/diff/1/Source/bindings/OWNERS File Source/bindings/OWNERS (right): https://codereview.chromium.org/16353004/diff/1/Source/bindings/OWNERS#newcode11 Source/bindings/OWNERS:11: ch.dumez@sisa.samsung.com Pls alphabetize this list. LGTM
7 years, 6 months ago (2013-06-10 15:09:40 UTC) #3
do-not-use
On 2013/06/10 15:09:40, abarth wrote: > https://codereview.chromium.org/16353004/diff/1/Source/bindings/OWNERS > File Source/bindings/OWNERS (right): > > https://codereview.chromium.org/16353004/diff/1/Source/bindings/OWNERS#newcode11 > ...
7 years, 6 months ago (2013-06-10 15:26:30 UTC) #4
haraken
> I fixed the alphabetization. > Can this be committed now or should I wait ...
7 years, 6 months ago (2013-06-11 00:53:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/16353004/6001
7 years, 6 months ago (2013-06-11 05:46:53 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=9291
7 years, 6 months ago (2013-06-11 07:43:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/16353004/6001
7 years, 6 months ago (2013-06-11 08:25:33 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 08:25:50 UTC) #9
Message was sent while issue was closed.
Change committed as 152203

Powered by Google App Engine
This is Rietveld 408576698