On X11, copy ANGLE's libraries instead of using the _ANGLE version

On X11, copy ANGLE's libraries instead of using the _ANGLE version

The _ANGLE version of the ANGLE libraries were loadable_module targets
linking against their respective shared_library. It worked in Debug
build but in Release builds the --as-needed linker flag removed the
dependency. Release Chromium would then be enable to find
eglGetProcAddress in libEGL_ANGLE and fail to start the GPU process.

This commit replaces the loadable_module scheme by a simple copy of the
libEGL and libGLESv2 shared libraries from PRODUCT_DIR/lib to
PRODUCT_DIR. The drawback to doing this is that the GYP and GN code
diverge (there is no need for the copy in GN).

BUG=522967
Committed: https://crrev.com/73c23eb5053aa6c70583b196a29ee5ec1b241143
Cr-Commit-Position: refs/heads/master@{#371821}

[Corentin Wallez, 2016-01-26 22:18:44]

Description was changed from

==========
On X11, copy ANGLE's libraries instead of using the _ANGLE version

The _ANGLE version of the ANGLE libraries were loadable_module targets
linking against their respective shared_library. It worked in Debug
build but in Release builds the --as-needed linker flag removed the
dependency. Release Chromium would then be enable to find
eglGetProcAddress in libEGL_ANGLE and fail to start the GPU process.

This commit replaces the loadable_module scheme by a simple copy of the
libEGL and libGLESv2 shared libraries from PRODUCT_DIR/lib to
PRODUCT_DIR. The drawback to doing this is that the GYP and GN code
diverge (there is no need for the copy in GN).

BUG=522967
==========

to

==========
On X11, copy ANGLE's libraries instead of using the _ANGLE version

The _ANGLE version of the ANGLE libraries were loadable_module targets
linking against their respective shared_library. It worked in Debug
build but in Release builds the --as-needed linker flag removed the
dependency. Release Chromium would then be enable to find
eglGetProcAddress in libEGL_ANGLE and fail to start the GPU process.

This commit replaces the loadable_module scheme by a simple copy of the
libEGL and libGLESv2 shared libraries from PRODUCT_DIR/lib to
PRODUCT_DIR. The drawback to doing this is that the GYP and GN code
diverge (there is no need for the copy in GN).

BUG=522967
==========

[Corentin Wallez, 2016-01-26 22:18:44]

cwallez@chromium.org changed reviewers:
+ kbr@chromium.org

[Corentin Wallez, 2016-01-26 22:19:37]

On 2016/01/26 22:18:44, cwallez1 wrote:
> mailto:cwallez@chromium.org changed reviewers:
> + mailto:kbr@chromium.org

PTAL, this is needed to add the WebGL CTS running on ANGLE on Linux (ANGLE has 3
less failures on my machine :D).

[Ken Russell (switch to Gerrit), 2016-01-26 23:02:10]

LGTM

I'm sure you'll do this anyway, but if the _ANGLE targets are then unused, let's
remove them from ANGLE.

[Corentin Wallez, 2016-01-27 16:51:47]

On 2016/01/26 23:02:10, Ken Russell wrote:
> LGTM
> 
> I'm sure you'll do this anyway, but if the _ANGLE targets are then unused,
let's
> remove them from ANGLE.

Thanks for the review. The ANGLE side cleanup is in the plans once this change
has landed. CQing

[Corentin Wallez, 2016-01-27 16:51:50]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-01-27 16:52:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1635243002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1635243002/1

[commit-bot: I haz the power, 2016-01-27 18:05:43]

Description was changed from

==========
On X11, copy ANGLE's libraries instead of using the _ANGLE version

The _ANGLE version of the ANGLE libraries were loadable_module targets
linking against their respective shared_library. It worked in Debug
build but in Release builds the --as-needed linker flag removed the
dependency. Release Chromium would then be enable to find
eglGetProcAddress in libEGL_ANGLE and fail to start the GPU process.

This commit replaces the loadable_module scheme by a simple copy of the
libEGL and libGLESv2 shared libraries from PRODUCT_DIR/lib to
PRODUCT_DIR. The drawback to doing this is that the GYP and GN code
diverge (there is no need for the copy in GN).

BUG=522967
==========

to

==========
On X11, copy ANGLE's libraries instead of using the _ANGLE version

The _ANGLE version of the ANGLE libraries were loadable_module targets
linking against their respective shared_library. It worked in Debug
build but in Release builds the --as-needed linker flag removed the
dependency. Release Chromium would then be enable to find
eglGetProcAddress in libEGL_ANGLE and fail to start the GPU process.

This commit replaces the loadable_module scheme by a simple copy of the
libEGL and libGLESv2 shared libraries from PRODUCT_DIR/lib to
PRODUCT_DIR. The drawback to doing this is that the GYP and GN code
diverge (there is no need for the copy in GN).

BUG=522967
==========

[commit-bot: I haz the power, 2016-01-27 18:05:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-27 18:06:47]

Description was changed from

==========
On X11, copy ANGLE's libraries instead of using the _ANGLE version

The _ANGLE version of the ANGLE libraries were loadable_module targets
linking against their respective shared_library. It worked in Debug
build but in Release builds the --as-needed linker flag removed the
dependency. Release Chromium would then be enable to find
eglGetProcAddress in libEGL_ANGLE and fail to start the GPU process.

This commit replaces the loadable_module scheme by a simple copy of the
libEGL and libGLESv2 shared libraries from PRODUCT_DIR/lib to
PRODUCT_DIR. The drawback to doing this is that the GYP and GN code
diverge (there is no need for the copy in GN).

BUG=522967
==========

to

==========
On X11, copy ANGLE's libraries instead of using the _ANGLE version

The _ANGLE version of the ANGLE libraries were loadable_module targets
linking against their respective shared_library. It worked in Debug
build but in Release builds the --as-needed linker flag removed the
dependency. Release Chromium would then be enable to find
eglGetProcAddress in libEGL_ANGLE and fail to start the GPU process.

This commit replaces the loadable_module scheme by a simple copy of the
libEGL and libGLESv2 shared libraries from PRODUCT_DIR/lib to
PRODUCT_DIR. The drawback to doing this is that the GYP and GN code
diverge (there is no need for the copy in GN).

BUG=522967

Committed: https://crrev.com/73c23eb5053aa6c70583b196a29ee5ec1b241143
Cr-Commit-Position: refs/heads/master@{#371821}
==========

[commit-bot: I haz the power, 2016-01-27 18:06:48]

Patchset 1 (id:??) landed as
https://crrev.com/73c23eb5053aa6c70583b196a29ee5ec1b241143
Cr-Commit-Position: refs/heads/master@{#371821}