Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 163523002: Clear button doesn't clear everything in memory section. (Closed)

Created:
6 years, 10 months ago by rtakacs
Modified:
6 years, 10 months ago
Reviewers:
loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Clear button doesn't clear everything in memory section. Clear all remaining measured information in order to restore the timeline panel to the initial state. R=loislo@chromium.org BUG=341438 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M Source/devtools/front_end/CountersGraph.js View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/MemoryStatistics.js View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/TimelineMemoryOverview.js View 1 chunk +9 lines, -1 line 0 comments Download
M Source/devtools/front_end/TimelineView.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
loislo
lgtm
6 years, 10 months ago (2014-02-14 13:29:46 UTC) #1
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 10 months ago (2014-02-14 13:29:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtakacs.u-szeged@partner.samsung.com/163523002/1
6 years, 10 months ago (2014-02-14 13:30:08 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 16:36:52 UTC) #4
Message was sent while issue was closed.
Change committed as 167208

Powered by Google App Engine
This is Rietveld 408576698