Service Worker: Deleting db iterator before closing db.

Service Worker: Deleting db iterator before closing db.

Common practice is to call Handle{Open/Read/Write}Result() when
using the leveldb database. Those functions will close the db
upon error - invalidating any open iterators. These calling
functions use scoped_ptr's for iterators which, upon error,
would delete an invalid leveldb::Iterator instance.

ServiceWorkerDatabase::DeleteResourceRecords()
ServiceWorkerDatabase::DeleteUserDataForRegistration()
ServiceWorkerDatabase::GetAllRegistrations()
ServiceWorkerDatabase::GetOriginsWithForeignFetchRegistrations()
ServiceWorkerDatabase::GetOriginsWithRegistrations()
ServiceWorkerDatabase::GetRegistrationsForOrigin()
ServiceWorkerDatabase::ReadResourceIds()
ServiceWorkerDatabase::ReadResourceRecords()
ServiceWorkerDatabase::ReadUserDataForAllRegistrations()

BUG=579624
Committed: https://crrev.com/768a502b9e4705d99ce314c081082f617f90badc
Cr-Commit-Position: refs/heads/master@{#371718}

[cmumford, 2016-01-26 21:25:59]

cmumford@chromium.org changed reviewers:
+ michaeln@chromium.org

[cmumford, 2016-01-26 21:42:33]

Description was changed from

==========
Service Worker: Deleting db iterator before closing db.

Common practice is to call Handle{Open/Read/Write}Result() when
using the leveldb database. Those functions will close the db
upon error - invalidating any open iterators. These calling
functions use scoped_ptr's for iterators which, upon any error,
would delete a dangling leveldb::Iterator instance.

ServiceWorkerDatabase::DeleteResourceRecords()
ServiceWorkerDatabase::DeleteUserDataForRegistration()
ServiceWorkerDatabase::GetAllRegistrations()
ServiceWorkerDatabase::GetOriginsWithForeignFetchRegistrations()
ServiceWorkerDatabase::GetOriginsWithRegistrations()
ServiceWorkerDatabase::GetRegistrationsForOrigin()
ServiceWorkerDatabase::ReadResourceIds()
ServiceWorkerDatabase::ReadResourceRecords()
ServiceWorkerDatabase::ReadUserDataForAllRegistrations()

BUG=579624
==========

to

==========
Service Worker: Deleting db iterator before closing db.

Common practice is to call Handle{Open/Read/Write}Result() when
using the leveldb database. Those functions will close the db
upon error - invalidating any open iterators. These calling
functions use scoped_ptr's for iterators which, upon error,
would delete an invalid leveldb::Iterator instance.

ServiceWorkerDatabase::DeleteResourceRecords()
ServiceWorkerDatabase::DeleteUserDataForRegistration()
ServiceWorkerDatabase::GetAllRegistrations()
ServiceWorkerDatabase::GetOriginsWithForeignFetchRegistrations()
ServiceWorkerDatabase::GetOriginsWithRegistrations()
ServiceWorkerDatabase::GetRegistrationsForOrigin()
ServiceWorkerDatabase::ReadResourceIds()
ServiceWorkerDatabase::ReadResourceRecords()
ServiceWorkerDatabase::ReadUserDataForAllRegistrations()

BUG=579624
==========

[michaeln, 2016-01-26 21:45:14]

lgtm

[cmumford, 2016-01-27 03:09:16]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2016-01-27 03:10:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1635223002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1635223002/1

[commit-bot: I haz the power, 2016-01-27 04:16:24]

Description was changed from

==========
Service Worker: Deleting db iterator before closing db.

Common practice is to call Handle{Open/Read/Write}Result() when
using the leveldb database. Those functions will close the db
upon error - invalidating any open iterators. These calling
functions use scoped_ptr's for iterators which, upon error,
would delete an invalid leveldb::Iterator instance.

ServiceWorkerDatabase::DeleteResourceRecords()
ServiceWorkerDatabase::DeleteUserDataForRegistration()
ServiceWorkerDatabase::GetAllRegistrations()
ServiceWorkerDatabase::GetOriginsWithForeignFetchRegistrations()
ServiceWorkerDatabase::GetOriginsWithRegistrations()
ServiceWorkerDatabase::GetRegistrationsForOrigin()
ServiceWorkerDatabase::ReadResourceIds()
ServiceWorkerDatabase::ReadResourceRecords()
ServiceWorkerDatabase::ReadUserDataForAllRegistrations()

BUG=579624
==========

to

==========
Service Worker: Deleting db iterator before closing db.

Common practice is to call Handle{Open/Read/Write}Result() when
using the leveldb database. Those functions will close the db
upon error - invalidating any open iterators. These calling
functions use scoped_ptr's for iterators which, upon error,
would delete an invalid leveldb::Iterator instance.

ServiceWorkerDatabase::DeleteResourceRecords()
ServiceWorkerDatabase::DeleteUserDataForRegistration()
ServiceWorkerDatabase::GetAllRegistrations()
ServiceWorkerDatabase::GetOriginsWithForeignFetchRegistrations()
ServiceWorkerDatabase::GetOriginsWithRegistrations()
ServiceWorkerDatabase::GetRegistrationsForOrigin()
ServiceWorkerDatabase::ReadResourceIds()
ServiceWorkerDatabase::ReadResourceRecords()
ServiceWorkerDatabase::ReadUserDataForAllRegistrations()

BUG=579624
==========

[commit-bot: I haz the power, 2016-01-27 04:16:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-27 04:18:42]

Description was changed from

==========
Service Worker: Deleting db iterator before closing db.

Common practice is to call Handle{Open/Read/Write}Result() when
using the leveldb database. Those functions will close the db
upon error - invalidating any open iterators. These calling
functions use scoped_ptr's for iterators which, upon error,
would delete an invalid leveldb::Iterator instance.

ServiceWorkerDatabase::DeleteResourceRecords()
ServiceWorkerDatabase::DeleteUserDataForRegistration()
ServiceWorkerDatabase::GetAllRegistrations()
ServiceWorkerDatabase::GetOriginsWithForeignFetchRegistrations()
ServiceWorkerDatabase::GetOriginsWithRegistrations()
ServiceWorkerDatabase::GetRegistrationsForOrigin()
ServiceWorkerDatabase::ReadResourceIds()
ServiceWorkerDatabase::ReadResourceRecords()
ServiceWorkerDatabase::ReadUserDataForAllRegistrations()

BUG=579624
==========

to

==========
Service Worker: Deleting db iterator before closing db.

Common practice is to call Handle{Open/Read/Write}Result() when
using the leveldb database. Those functions will close the db
upon error - invalidating any open iterators. These calling
functions use scoped_ptr's for iterators which, upon error,
would delete an invalid leveldb::Iterator instance.

ServiceWorkerDatabase::DeleteResourceRecords()
ServiceWorkerDatabase::DeleteUserDataForRegistration()
ServiceWorkerDatabase::GetAllRegistrations()
ServiceWorkerDatabase::GetOriginsWithForeignFetchRegistrations()
ServiceWorkerDatabase::GetOriginsWithRegistrations()
ServiceWorkerDatabase::GetRegistrationsForOrigin()
ServiceWorkerDatabase::ReadResourceIds()
ServiceWorkerDatabase::ReadResourceRecords()
ServiceWorkerDatabase::ReadUserDataForAllRegistrations()

BUG=579624

Committed: https://crrev.com/768a502b9e4705d99ce314c081082f617f90badc
Cr-Commit-Position: refs/heads/master@{#371718}
==========

[commit-bot: I haz the power, 2016-01-27 04:18:43]

Patchset 1 (id:??) landed as
https://crrev.com/768a502b9e4705d99ce314c081082f617f90badc
Cr-Commit-Position: refs/heads/master@{#371718}