Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1635203002: Apply text indent if the text direction matches the text alignment (Closed)

Created:
4 years, 11 months ago by rhogan
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply text indent if the text direction matches the text alignment We text-align:left; our <li> elements so this shows up on live-sites that attempt a text indent on their the list element's content. BUG=568851 Committed: https://crrev.com/d7ea97a4c74a4f420f8a646109f15f32f61c419e Cr-Commit-Position: refs/heads/master@{#371665}

Patch Set 1 #

Messages

Total messages: 13 (6 generated)
rhogan
4 years, 11 months ago (2016-01-26 20:08:03 UTC) #3
eae
LGTM The test seems a bit over complicated but does cover the change so it's ...
4 years, 11 months ago (2016-01-26 20:45:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635203002/1
4 years, 11 months ago (2016-01-26 20:46:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/170539) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
4 years, 11 months ago (2016-01-26 21:28:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635203002/1
4 years, 11 months ago (2016-01-26 22:03:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 00:52:07 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 00:53:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7ea97a4c74a4f420f8a646109f15f32f61c419e
Cr-Commit-Position: refs/heads/master@{#371665}

Powered by Google App Engine
This is Rietveld 408576698