Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 16352002: Rename CrossOperationDelegate to CopyOrMoveOperationDelegate (Closed)

Created:
7 years, 6 months ago by kinuko
Modified:
7 years, 6 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org
Visibility:
Public.

Description

Rename CrossOperationDelegate to CopyOrMoveOperationDelegate To make it crystal clear what it does. BUG=240658 TEST=CopyOrMoveOperationDelegateTest.* R=nhiroki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -866 lines) Patch
M content/content_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/copy_or_move_operation_delegate.h View 5 chunks +9 lines, -9 lines 0 comments Download
A + webkit/browser/fileapi/copy_or_move_operation_delegate.cc View 13 chunks +24 lines, -24 lines 0 comments Download
A + webkit/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 8 chunks +28 lines, -28 lines 0 comments Download
D webkit/browser/fileapi/cross_operation_delegate.h View 1 chunk +0 lines, -123 lines 0 comments Download
D webkit/browser/fileapi/cross_operation_delegate.cc View 1 chunk +0 lines, -246 lines 0 comments Download
D webkit/browser/fileapi/local_file_system_cross_operation_unittest.cc View 1 chunk +0 lines, -428 lines 0 comments Download
M webkit/browser/fileapi/local_file_system_operation.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/browser/fileapi/webkit_browser_fileapi.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kinuko
PTL, I believe this rename is pretty reasonable!
7 years, 6 months ago (2013-06-04 05:29:58 UTC) #1
nhiroki
lgtm
7 years, 6 months ago (2013-06-04 05:54:29 UTC) #2
kinuko
7 years, 6 months ago (2013-06-04 06:57:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r203880.

Powered by Google App Engine
This is Rietveld 408576698