Issue 1635173003: Move struct ContentParam off of CPDF_Object's enums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1635173003: Move struct ContentParam off of CPDF_Object's enums (Closed)

Created:
4 years, 11 months ago by Tom Sepez

Modified:
4 years, 11 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Move struct ContentParam off of CPDF_Object's enums They mean different things. The goal is that only usage of the CPDF_Object type enums outside of the class should be for switch() statements, so remove one other comparison. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0ec8bb4486ab315283f36d071be2ddc1b80998c3

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -29 lines)			Patch
M	core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp	View	5 chunks	+26 lines, -26 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/pageint.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Tom Sepez

4 years, 11 months ago (2016-01-26 21:28:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0ec8bb4486ab315283f36d071be2ddc1b80998c3 (presubmit successful).