Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1635173002: DevTools: do not rely upon reported context having accessible injected script. (Closed)

Created:
4 years, 11 months ago by pfeldman
Modified:
4 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: do not rely upon reported context having accessible injected script. NOTRY=true Committed: https://crrev.com/26d9773b1b7d22c44f960335194b441dc58babce Cr-Commit-Position: refs/heads/master@{#371621}

Patch Set 1 #

Total comments: 1

Patch Set 2 : changed keyboard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
pfeldman
4 years, 11 months ago (2016-01-26 19:12:08 UTC) #2
dgozman
Should we do similar checks in other places, e.g. DOM agent? lgtm https://codereview.chromium.org/1635173002/diff/1/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp File third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp ...
4 years, 11 months ago (2016-01-26 19:41:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635173002/20001
4 years, 11 months ago (2016-01-26 20:07:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/13068) android_compile_dbg on tryserver.chromium.android (JOB_FAILED, ...
4 years, 11 months ago (2016-01-26 20:19:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635173002/20001
4 years, 11 months ago (2016-01-26 22:29:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 22:37:53 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 22:39:26 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26d9773b1b7d22c44f960335194b441dc58babce
Cr-Commit-Position: refs/heads/master@{#371621}

Powered by Google App Engine
This is Rietveld 408576698