Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1635153002: Remove potential unsatisfied linker error. (Closed)

Created:
4 years, 11 months ago by Peter Wen
Modified:
4 years, 11 months ago
Reviewers:
Ted C, Yaron
CC:
chromium-reviews, Ted C
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove potential unsatisfied linker error. BUG=543201 NOTRY=true Committed: https://crrev.com/bf9913493217d1821c8fdb7bbb18afa9e6b4f76d Cr-Commit-Position: refs/heads/master@{#371564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java View 4 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Peter Wen
Hi Yaron and Ted, Removing this potential exception for now. Will add it with a ...
4 years, 11 months ago (2016-01-26 18:30:21 UTC) #2
Yaron
lgtm
4 years, 11 months ago (2016-01-26 18:30:49 UTC) #3
Ted C
lgtm
4 years, 11 months ago (2016-01-26 18:43:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635153002/1
4 years, 11 months ago (2016-01-26 19:38:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 19:44:20 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bf9913493217d1821c8fdb7bbb18afa9e6b4f76d Cr-Commit-Position: refs/heads/master@{#371564}
4 years, 11 months ago (2016-01-26 19:45:44 UTC) #14
jbudorick
On 2016/01/26 19:45:44, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 11 months ago (2016-01-26 20:30:45 UTC) #15
Peter Wen
4 years, 11 months ago (2016-01-26 20:31:54 UTC) #16
Message was sent while issue was closed.
On 2016/01/26 20:30:45, jbudorick wrote:
> On 2016/01/26 19:45:44, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/bf9913493217d1821c8fdb7bbb18afa9e6b4f76d
> > Cr-Commit-Position: refs/heads/master@{#371564}
> 
> NOTRY? :(

Sorry, John. Thought nothing depended on this so didn't want to waste the try
jobs. :(

Will run next time even if I think otherwise, just in case.

Powered by Google App Engine
This is Rietveld 408576698