Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 163513003: Revert "Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField." (Closed)

Created:
6 years, 10 months ago by floitsch
Modified:
6 years, 10 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, karlklose
Visibility:
Public.

Description

Revert "Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField." This reverts commit r32650. Committed: https://code.google.com/p/dart/source/detail?r=32652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -49 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/namer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download
D tests/language/null2_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
M tests/language/null_test.dart View 1 chunk +1 line, -4 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -0 lines 0 comments Download
D tests/lib/mirrors/null2_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
Two failing tests. Will debug.
6 years, 10 months ago (2014-02-13 13:46:10 UTC) #1
floitsch
TBR.
6 years, 10 months ago (2014-02-13 13:46:18 UTC) #2
floitsch
Committed patchset #1 manually as r32652 (presubmit successful).
6 years, 10 months ago (2014-02-13 13:46:47 UTC) #3
kasperl
6 years, 10 months ago (2014-02-13 13:50:36 UTC) #4
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698