Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1635113002: Promptly let go of WebURLLoader objects. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Promptly let go of WebURLLoader objects. The objects keeping their own WebURLLoaders (and thus being WebURLLoaderClients) must promptly let go of their ownership upon becoming garbage. Not doing so risks the embedder calling the client while it is in a sweepable state. R= BUG=568173 Committed: https://crrev.com/8da2e8e24b443e9c5650b180e2e8253de422c7b8 Cr-Commit-Position: refs/heads/master@{#371639}

Patch Set 1 #

Patch Set 2 : fix decls.. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/core/fetch/ResourceLoader.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635113002/1
4 years, 11 months ago (2016-01-26 15:39:35 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/84358)
4 years, 11 months ago (2016-01-26 15:50:00 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635113002/20001
4 years, 11 months ago (2016-01-26 15:56:52 UTC) #6
sof
please take a look. (too many of these to prefinalize.)
4 years, 11 months ago (2016-01-26 16:43:20 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-26 17:21:23 UTC) #10
haraken
LGTM
4 years, 11 months ago (2016-01-26 23:40:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635113002/20001
4 years, 11 months ago (2016-01-26 23:41:50 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 23:52:36 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8da2e8e24b443e9c5650b180e2e8253de422c7b8 Cr-Commit-Position: refs/heads/master@{#371639}
4 years, 11 months ago (2016-01-26 23:53:46 UTC) #16
sof
thanks, let's watch status in the next canary builds.
4 years, 11 months ago (2016-01-27 06:20:02 UTC) #17
sof
Sorry about having to make these requests, but could someone Cc: me on 568173, please? ...
4 years, 11 months ago (2016-01-28 10:47:46 UTC) #18
haraken
4 years, 11 months ago (2016-01-28 10:49:05 UTC) #19
Message was sent while issue was closed.
On 2016/01/28 10:47:46, sof wrote:
> Sorry about having to make these requests, but could someone Cc: me on 568173,
> please? Have been locked out from accessing. TIA.

Sorry, I forgot to add "f" :)

Powered by Google App Engine
This is Rietveld 408576698