Move pub over to using the pub.dartlang.org API v2.

Move pub over to using the pub.dartlang.org API v2.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23615

[Bob Nystrom, 2013-06-04 20:21:41]

Some suggestions then LGTM.

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/http.dart (right):

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/http.dart:11: import 'dart:typed_data';
Remove this?

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/http.dart:34: final PUB_API_HEADERS = {'Accept':
'application/vnd.pub.v2+json'};
final -> const

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/pubspec.dart (right):

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/pubspec.dart:81: factory Pubspec.fromMap(Map
contents, SourceRegistry sources) =>
"map" seems weird to me here. Maybe "Json"?

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/test/ho...
File sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart (right):

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/test/ho...
sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart:39:
forBothPubInstallAndUpdate((command) {
Other tests just wrap all of the integration() calls in a single
forBothPubInstallAndUpdate.

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/test/ho...
sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart:40:
integration('prints a user-friendly error if the version is out-of-date',
"user-friendly" -> "friendly", just to get rid of that wrapped "() {" :)

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/test/ho...
sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart:68:
"pub.dartlang.org.\n"
Shouldn't it use the actual server URL here?

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/test/te...
File sdk/lib/_internal/pub/test/test_pub.dart (right):

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/test/te...
sdk/lib/_internal/pub/test/test_pub.dart:166: /// A map from package names to
version numbers to parsed pubspec maps for those
Remove "to version numbers".

[nweiz, 2013-06-04 21:04:17]

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/http.dart (right):

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/http.dart:11: import 'dart:typed_data';
On 2013/06/04 20:21:41, Bob Nystrom wrote:
> Remove this?

Done.

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/http.dart:34: final PUB_API_HEADERS = {'Accept':
'application/vnd.pub.v2+json'};
On 2013/06/04 20:21:41, Bob Nystrom wrote:
> final -> const

Done.

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/pubspec.dart (right):

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/pubspec.dart:81: factory Pubspec.fromMap(Map
contents, SourceRegistry sources) =>
On 2013/06/04 20:21:41, Bob Nystrom wrote:
> "map" seems weird to me here. Maybe "Json"?

That's confusing, because it's not parsing JSON. This is in no way
JSON-specific; it works just as well with parsed YAML.

I think this just feels weird because we don't usually think of Dart maps as a
generic object format, but I do think this is the clearest name.

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/test/ho...
File sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart (right):

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/test/ho...
sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart:39:
forBothPubInstallAndUpdate((command) {
On 2013/06/04 20:21:41, Bob Nystrom wrote:
> Other tests just wrap all of the integration() calls in a single
> forBothPubInstallAndUpdate.

Done.

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/test/ho...
sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart:40:
integration('prints a user-friendly error if the version is out-of-date',
On 2013/06/04 20:21:41, Bob Nystrom wrote:
> "user-friendly" -> "friendly", just to get rid of that wrapped "() {" :)

Done.

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/test/ho...
sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart:68:
"pub.dartlang.org.\n"
On 2013/06/04 20:21:41, Bob Nystrom wrote:
> Shouldn't it use the actual server URL here?

Done.

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/test/te...
File sdk/lib/_internal/pub/test/test_pub.dart (right):

https://codereview.chromium.org/16351003/diff/1/sdk/lib/_internal/pub/test/te...
sdk/lib/_internal/pub/test/test_pub.dart:166: /// A map from package names to
version numbers to parsed pubspec maps for those
On 2013/06/04 20:21:41, Bob Nystrom wrote:
> Remove "to version numbers".

Done.

[nweiz, 2013-06-04 21:05:10]

Committed patchset #2 manually as r23615 (presubmit successful).