pkg/analyzer/test/src/summary/resynthesize_test.dart - Issue 1635063003: Stop precomputing ClassElement.isValidMixin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_test.dart

Issue 1635063003: Stop precomputing ClassElement.isValidMixin. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/test/src/summary/resynthesize_test.dart

diff --git a/pkg/analyzer/test/src/summary/resynthesize_test.dart b/pkg/analyzer/test/src/summary/resynthesize_test.dart

index db8c43a48abd796d2c62239540aad5cc01969d74..0e7843d57c44085f1457ba8948806d263e5fdf74 100644

--- a/pkg/analyzer/test/src/summary/resynthesize_test.dart

+++ b/pkg/analyzer/test/src/summary/resynthesize_test.dart

@@ -220,10 +220,6 @@ class ResynthTest extends ResolverTestCase {

ElementImpl actualResynthesized = getActualElement(resynthesized, desc);

ElementImpl actualOriginal = getActualElement(original, desc);

for (Modifier modifier in Modifier.values) {

- if (modifier == Modifier.MIXIN) {

- // Skipping for now. TODO(paulberry): fix.

- continue;

- }

bool got = actualResynthesized.hasModifier(modifier);

bool want = actualOriginal.hasModifier(modifier);

expect(got, want,