Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1635043002: Rename web_restriction -> web_restrictions. (Closed)

Created:
4 years, 11 months ago by knn
Modified:
4 years, 11 months ago
Reviewers:
Bernhard Bauer, aberent
CC:
chromium-reviews, cpu_(ooo_6.6-7.5)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename web_restriction -> web_restrictions. TBR=cpu@chromium.org BUG=569879 Committed: https://crrev.com/19b664f13533ebdeb683fa017181f5c4db4ebb26 Cr-Commit-Position: refs/heads/master@{#371551}

Patch Set 1 #

Patch Set 2 : fix DEPS #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -391 lines) Patch
M chrome/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProvider.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/components.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
D components/web_restriction.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
D components/web_restriction/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D components/web_restriction/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/web_restriction/java/src/org/chromium/components/webrestriction/WebRestrictionsContentProvider.java View 1 chunk +0 lines, -188 lines 0 comments Download
D components/web_restriction/junit/src/org/chromium/components/webrestriction/WebRestrictionsContentProviderTest.java View 1 chunk +0 lines, -139 lines 0 comments Download
A + components/web_restrictions.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/web_restrictions/BUILD.gn View 1 chunk +5 lines, -5 lines 0 comments Download
A + components/web_restrictions/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/web_restrictions/java/src/org/chromium/components/webrestrictions/WebRestrictionsContentProvider.java View 1 chunk +1 line, -1 line 0 comments Download
A + components/web_restrictions/junit/src/org/chromium/components/webrestrictions/WebRestrictionsContentProviderTest.java View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
knn
PLease review. I'll TBR everyone else.
4 years, 11 months ago (2016-01-26 11:50:02 UTC) #2
Bernhard Bauer
LGTM, thanks!
4 years, 11 months ago (2016-01-26 12:04:02 UTC) #3
aberent
lgtm
4 years, 11 months ago (2016-01-26 12:06:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635043002/40001
4 years, 11 months ago (2016-01-26 16:47:53 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/13008)
4 years, 11 months ago (2016-01-26 17:28:09 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635043002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635043002/60001
4 years, 11 months ago (2016-01-26 17:46:27 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-26 18:53:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635043002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635043002/60001
4 years, 11 months ago (2016-01-26 18:58:16 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 11 months ago (2016-01-26 19:06:20 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 19:08:44 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/19b664f13533ebdeb683fa017181f5c4db4ebb26
Cr-Commit-Position: refs/heads/master@{#371551}

Powered by Google App Engine
This is Rietveld 408576698