Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1635033002: Revert of Add API for custom library loading (Closed)

Created:
4 years, 11 months ago by aberent
Modified:
4 years, 11 months ago
Reviewers:
mgersh, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add API for custom library loading (patchset #5 id:80001 of https://codereview.chromium.org/1619673004/ ) Reason for revert: New test (CronetUrlRequestContextTest#testSkipLibraryLoading) fails on bots BUG=581309 Original issue's description: > Add API for custom library loading > > Loading the native library can cause a crash on some older versions of > Android. This CL provides a way for embedders to implement custom library > loading logic that works around the issue. > > BUG=550584 > R=xunjieli@chromium.org > > Committed: https://crrev.com/12d01cb35ec0ed7a259c19dd1390b5a486d61a9d > Cr-Commit-Position: refs/heads/master@{#371319} TBR=xunjieli@chromium.org,mgersh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=550584 Committed: https://crrev.com/06c22d9842ecb9a92cda7795ce617f55a612f537 Cr-Commit-Position: refs/heads/master@{#371489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -65 lines) Patch
M components/cronet/android/api/src/org/chromium/net/CronetEngine.java View 3 chunks +2 lines, -32 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java View 2 chunks +2 lines, -2 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
aberent
Created Revert of Add API for custom library loading
4 years, 11 months ago (2016-01-26 11:14:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635033002/1
4 years, 11 months ago (2016-01-26 11:14:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 11:15:07 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 11:16:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06c22d9842ecb9a92cda7795ce617f55a612f537
Cr-Commit-Position: refs/heads/master@{#371489}

Powered by Google App Engine
This is Rietveld 408576698