Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1634973003: DrMemory: Disable flaky Webrtc/ConnectionTest.Video/0. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DrMemory: Disable flaky Webrtc/ConnectionTest.Video/0. BUG=581519 TBR=groby@chromium.org Committed: https://crrev.com/fc6d823dad018aa13d5efa89bfc7ee83e0edbbbb Cr-Commit-Position: refs/heads/master@{#371646}

Patch Set 1 #

Patch Set 2 : fix typos #

Patch Set 3 : DrMemory only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Lei Zhang
TBR
4 years, 11 months ago (2016-01-26 23:21:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634973003/1
4 years, 11 months ago (2016-01-26 23:21:49 UTC) #3
Lei Zhang
... and fixed some typos.
4 years, 11 months ago (2016-01-26 23:27:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634973003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634973003/20001
4 years, 11 months ago (2016-01-26 23:30:12 UTC) #9
Lei Zhang
... and make it DrMemory only. Third time is the charm?
4 years, 11 months ago (2016-01-26 23:33:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634973003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634973003/40001
4 years, 11 months ago (2016-01-26 23:37:40 UTC) #13
groby-ooo-7-16
Well, at this point, LGTM :)
4 years, 11 months ago (2016-01-26 23:56:09 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-27 00:08:32 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 00:09:44 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fc6d823dad018aa13d5efa89bfc7ee83e0edbbbb
Cr-Commit-Position: refs/heads/master@{#371646}

Powered by Google App Engine
This is Rietveld 408576698