Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 1634943003: Replace if-block on !redirectResponse.isNull() with ASSERT in RawResource::willFollowRedirect() (Closed)

Created:
4 years, 11 months ago by tyoshino (SeeGerritForStatus)
Modified:
4 years, 11 months ago
Reviewers:
Nate Chapin, Mike West
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace if-block on !redirectResponse.isNull() with ASSERT in RawResource::willFollowRedirect() The only caller ResourceLoader::willFollowRedirect() has ASSERT on redirectResponse. So, we can assert that it's not null here too. BUG=none R=mkwst Committed: https://crrev.com/feb0860c3c3ab9ece8cb92d8ca23cf57f8196498 Cr-Commit-Position: refs/heads/master@{#371707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/Source/core/fetch/RawResource.cpp View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634943003/1
4 years, 11 months ago (2016-01-26 08:24:50 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-26 09:40:43 UTC) #6
Mike West
On 2016/01/26 at 09:40:43, commit-bot wrote: > Dry run: This issue passed the CQ dry ...
4 years, 11 months ago (2016-01-26 09:56:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634943003/1
4 years, 11 months ago (2016-01-27 03:26:32 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 03:37:14 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 03:38:38 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/feb0860c3c3ab9ece8cb92d8ca23cf57f8196498
Cr-Commit-Position: refs/heads/master@{#371707}

Powered by Google App Engine
This is Rietveld 408576698