remoting: Add AttachmentBroker for daemon and desktop processes

remoting/host/daemon_process.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/daemon_process.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback_helpers.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
+#include "ipc/attachment_broker_privileged.h"
 #include "net/base/net_util.h"
 #include "remoting/base/auto_thread_task_runner.h"
 #include "remoting/host/branding.h"
 #include "remoting/host/chromoting_messages.h"
 #include "remoting/host/config_file_watcher.h"
 #include "remoting/host/desktop_session.h"
 #include "remoting/host/host_event_logger.h"
 #include "remoting/host/host_exit_codes.h"
 #include "remoting/host/host_status_observer.h"
 #include "remoting/host/screen_resolution.h"
@@ skipping 148 matching lines @@
 DaemonProcess::DaemonProcess(
     scoped_refptr<AutoThreadTaskRunner> caller_task_runner,
     scoped_refptr<AutoThreadTaskRunner> io_task_runner,
     const base::Closure& stopped_callback)
     : caller_task_runner_(caller_task_runner),
       io_task_runner_(io_task_runner),
       next_terminal_id_(0),
       stopped_callback_(stopped_callback),
       weak_factory_(this) {
   DCHECK(caller_task_runner->BelongsToCurrentThread());
+
+  IPC::AttachmentBrokerPrivileged::CreateBrokerIfNeeded();

[joedow, 2016/01/26 21:42:51]

It looks like this method has different args for OSX and I believe this file is
compiled into our mac host.  Does this need a conditional around it for OSX vs.
other host builds?

[erikchen, 2016/01/26 21:47:00]

Oh, yes. The Chrome browser process, on Mac, has a Port Provider
(base::PortProvider) which provides the task port of its child processes. This
is also required for attachment brokering. I'm surprised this hasn't broken on
Mac since we've been passing Mach SharedMemoryHandles on Mac since M49.

[Sergey Ulanov, 2016/01/27 01:38:39]

There are some files like this one that are compiled only on platform that don't
use multi-process hosts (i.e. OSX and Linux). This is mainly so that this code
can be unittested on all platforms and to make it easier to enabled
multi-process when necessary.
IPC::AttachmentBrokerPrivileged::CreateBrokerIfNeeded() doesn't do anything on
Linux, but we can still call it. OSX does need attachment broker.

[Sergey Ulanov, 2016/01/27 01:43:02]

We are not using this code on OSX.

Updated this code to compile on OSX now.

Erik, is it possible to update CreateBrokerIfNeeded() to
callMachBroker::GetInstance()? then initialization here wouldn't need to be
platform-specific

[erikchen, 2016/01/27 15:16:41]

If this code isn't being used on OSX, why is it being compiled on OSX? I'm
hesitant to make changes that make it easier to incorrectly use an API. It
doesn't make sense to instantiate a privileged AttachmentBroker without a Mach
broker.

Can we just wrap this in !defined(OS_MACOSX)?

[Sergey Ulanov, 2016/01/27 18:29:12]

The goal is to implement multi-process host on OSX as well, and maybe eventually
on Linux.
Done.

 }
 
 void DaemonProcess::CreateDesktopSession(int terminal_id,
                                          const ScreenResolution& resolution,
                                          bool virtual_terminal) {
   DCHECK(caller_task_runner()->BelongsToCurrentThread());
 
   // Validate the supplied terminal ID. An attempt to create a desktop session
   // with an ID that could possibly have been allocated already is considered
   // a protocol error and the network process will be restarted.
@@ skipping 177 matching lines @@
 }
 
 void DaemonProcess::DeleteAllDesktopSessions() {
   while (!desktop_sessions_.empty()) {
     delete desktop_sessions_.front();
     desktop_sessions_.pop_front();
   }
 }
 
 }  // namespace remoting