Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1475)

Unified Diff: content/child/notifications/notification_manager.h

Issue 1634933006: Use NotificationResources instead of a bare SkBitmap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit tests. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/notifications/notification_manager.h
diff --git a/content/child/notifications/notification_manager.h b/content/child/notifications/notification_manager.h
index 8eb64690bb49d69d73a019c7a027df5240465969..8b69a0b0e42913f81d28df0a3edb812a6cf0e2c6 100644
--- a/content/child/notifications/notification_manager.h
+++ b/content/child/notifications/notification_manager.h
@@ -22,10 +22,9 @@
#include "content/public/child/worker_thread.h"
#include "third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h"
-class SkBitmap;
-
namespace content {
+struct NotificationResources;
struct PlatformNotificationData;
class ThreadSafeSender;
@@ -91,7 +90,7 @@ class NotificationManager : public blink::WebNotificationManager,
const blink::WebSecurityOrigin& origin,
const blink::WebNotificationData& notification_data,
blink::WebNotificationDelegate* delegate,
- const SkBitmap& icon);
+ const NotificationResources& notification_resources);
// To be called when a persistent notification is ready to be displayed. Will
// inform the browser process about all available data. The |callbacks| will
@@ -102,14 +101,14 @@ class NotificationManager : public blink::WebNotificationManager,
const blink::WebNotificationData& notification_data,
int64_t service_worker_registration_id,
scoped_ptr<blink::WebNotificationShowCallbacks> callbacks,
- const SkBitmap& icon);
+ const NotificationResources& notification_resources);
scoped_refptr<ThreadSafeSender> thread_safe_sender_;
scoped_refptr<NotificationDispatcher> notification_dispatcher_;
// Tracker which stores all pending Notifications, both page and persistent
// ones, until all their associated resources have been fetched.
- PendingNotificationsTracker pending_notifications_;
+ PendingNotificationsTracker notifications_tracker_;
// Tracks pending requests for getting a list of notifications.
IDMap<blink::WebNotificationGetCallbacks, IDMapOwnPointer>
« no previous file with comments | « content/browser/notifications/notification_message_filter.cc ('k') | content/child/notifications/notification_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698