Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.h

Issue 1634933006: Use NotificationResources instead of a bare SkBitmap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit tests. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/notifications/platform_notification_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/platform_notification_service_impl.h
diff --git a/chrome/browser/notifications/platform_notification_service_impl.h b/chrome/browser/notifications/platform_notification_service_impl.h
index eb694dff73b42782d4d37584cca19deebe004d75..a7978d9666332613544cfc23688f87897399e9bb 100644
--- a/chrome/browser/notifications/platform_notification_service_impl.h
+++ b/chrome/browser/notifications/platform_notification_service_impl.h
@@ -25,6 +25,7 @@ class NotificationUIManager;
namespace content {
class BrowserContext;
+struct NotificationResources;
}
namespace gcm {
@@ -95,16 +96,16 @@ class PlatformNotificationServiceImpl
void DisplayNotification(
content::BrowserContext* browser_context,
const GURL& origin,
- const SkBitmap& icon,
const content::PlatformNotificationData& notification_data,
+ const content::NotificationResources& notification_resources,
scoped_ptr<content::DesktopNotificationDelegate> delegate,
base::Closure* cancel_callback) override;
void DisplayPersistentNotification(
content::BrowserContext* browser_context,
int64_t persistent_notification_id,
const GURL& origin,
- const SkBitmap& icon,
- const content::PlatformNotificationData& notification_data) override;
+ const content::PlatformNotificationData& notification_data,
+ const content::NotificationResources& notification_resources) override;
void ClosePersistentNotification(
content::BrowserContext* browser_context,
int64_t persistent_notification_id) override;
@@ -131,8 +132,8 @@ class PlatformNotificationServiceImpl
Notification CreateNotificationFromData(
Profile* profile,
const GURL& origin,
- const SkBitmap& icon,
const content::PlatformNotificationData& notification_data,
+ const content::NotificationResources& notification_resources,
NotificationDelegate* delegate) const;
// Overrides the Notification UI Manager to use to |manager|. Only to be
« no previous file with comments | « no previous file | chrome/browser/notifications/platform_notification_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698