Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: tools/battor_agent/battor_agent_unittest.cc

Issue 1634933005: tools/battor_agent: Fix unit test compile warnings on other platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/battor_agent/battor_sample_converter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/battor_agent/battor_agent_unittest.cc
diff --git a/tools/battor_agent/battor_agent_unittest.cc b/tools/battor_agent/battor_agent_unittest.cc
index ad86f4879206fc84c059755bf271b7e80b0da9c5..d1b43e9638c1cc36a3d21e3987ab18bd23f3de7c 100644
--- a/tools/battor_agent/battor_agent_unittest.cc
+++ b/tools/battor_agent/battor_agent_unittest.cc
@@ -472,9 +472,8 @@ TEST_F(BattOrAgentTest, StopTracing) {
// Send an empty last frame to indicate that we're done.
BattOrFrameHeader frame_header3{0, 0 * sizeof(RawBattOrSample)};
- RawBattOrSample frame3[] = {};
GetAgent()->OnMessageRead(true, BATTOR_MESSAGE_TYPE_SAMPLES,
- CreateFrame(frame_header3, frame3, 0));
+ CreateFrame(frame_header3, nullptr, 0));
EXPECT_TRUE(IsCommandComplete());
EXPECT_EQ(BATTOR_ERROR_NONE, GetCommandError());
@@ -523,9 +522,8 @@ TEST_F(BattOrAgentTest, StopTracingRetriesEEPROMRead) {
GetTaskRunner()->RunUntilIdle();
BattOrFrameHeader frame_header{0, 0};
- RawBattOrSample frame[] = {};
GetAgent()->OnMessageRead(true, BATTOR_MESSAGE_TYPE_SAMPLES,
- CreateFrame(frame_header, frame, 0));
+ CreateFrame(frame_header, nullptr, 0));
GetTaskRunner()->RunUntilIdle();
EXPECT_TRUE(IsCommandComplete());
@@ -577,9 +575,8 @@ TEST_F(BattOrAgentTest, StopTracingSucceedsWithOneCalibrationFrameReadFailure) {
GetTaskRunner()->RunUntilIdle();
BattOrFrameHeader frame_header{0, 0};
- RawBattOrSample frame[] = {};
GetAgent()->OnMessageRead(true, BATTOR_MESSAGE_TYPE_SAMPLES,
- CreateFrame(frame_header, frame, 0));
+ CreateFrame(frame_header, nullptr, 0));
GetTaskRunner()->RunUntilIdle();
EXPECT_TRUE(IsCommandComplete());
@@ -607,9 +604,8 @@ TEST_F(BattOrAgentTest, StopTracingSucceedsWithOneDataFrameReadFailure) {
GetTaskRunner()->RunUntilIdle();
BattOrFrameHeader frame_header{0, 0};
- RawBattOrSample frame[] = {};
GetAgent()->OnMessageRead(true, BATTOR_MESSAGE_TYPE_SAMPLES,
- CreateFrame(frame_header, frame, 0));
+ CreateFrame(frame_header, nullptr, 0));
GetTaskRunner()->RunUntilIdle();
EXPECT_TRUE(IsCommandComplete());
@@ -651,9 +647,8 @@ TEST_F(BattOrAgentTest, StopTracingRetriesResetEachFrame) {
}
BattOrFrameHeader frame_header2{0, 0};
- RawBattOrSample frame2[] = {};
GetAgent()->OnMessageRead(true, BATTOR_MESSAGE_TYPE_SAMPLES,
- CreateFrame(frame_header2, frame2, 0));
+ CreateFrame(frame_header2, nullptr, 0));
GetTaskRunner()->RunUntilIdle();
EXPECT_TRUE(IsCommandComplete());
« no previous file with comments | « no previous file | tools/battor_agent/battor_sample_converter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698