Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1634933005: tools/battor_agent: Fix unit test compile warnings on other platforms (Closed)

Created:
4 years, 11 months ago by charliea (OOO until 10-5)
Modified:
4 years, 11 months ago
Reviewers:
Zhen Wang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/battor_agent: Fix unit test compile warnings on other platforms These tests were causing compile warnings on platforms other than Linux. Now that I'm trying to get the battor_agent tests on the waterfall, this is problematic. TBR=zhenw@chromium.org Committed: https://crrev.com/057026e9c41fb67cdd2998a4697b1764236c7cc5 Cr-Commit-Position: refs/heads/master@{#371516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -44 lines) Patch
M tools/battor_agent/battor_agent_unittest.cc View 5 chunks +5 lines, -10 lines 0 comments Download
M tools/battor_agent/battor_sample_converter_unittest.cc View 6 chunks +34 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
charliea (OOO until 10-5)
4 years, 11 months ago (2016-01-26 15:14:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634933005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634933005/1
4 years, 11 months ago (2016-01-26 15:15:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 15:34:22 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 15:35:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/057026e9c41fb67cdd2998a4697b1764236c7cc5
Cr-Commit-Position: refs/heads/master@{#371516}

Powered by Google App Engine
This is Rietveld 408576698